Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test(autoware_vehicle_info_utils): add tests for missed lines #271

Merged
merged 6 commits into from
Mar 26, 2025
Merged

test(autoware_vehicle_info_utils): add tests for missed lines #271

merged 6 commits into from
Mar 26, 2025

Conversation

NorahXiong
Copy link
Contributor

Description

Related links

Parent Issue:

#131

How was this PR tested?

Notes for reviewers

None.

Interface changes

None.

Effects on system behavior

None.

@NorahXiong NorahXiong added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Mar 13, 2025
@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 13, 2025 •
edited
Loading

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

@codecov Codecov
Copy link

codecov bot commented Mar 13, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 20.06%. Comparing base (4cb18f5) to head (0baf7bc).
Report is 102 commits behind head on main.

Additional details and impacted files 
@@             Coverage Diff             @@
##             main     #271       +/-   ##
===========================================
- Coverage   78.75%   20.06%   -58.70%     
===========================================
  Files          11       95       +84     
  Lines         193     4292     +4099     
  Branches       73      927      +854     
===========================================
+ Hits          152      861      +709     
- Misses         11     3326     +3315     
- Partials       30      105       +75
Flag Coverage Δ
differential 20.06% <ø> (?)
total ?

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@NorahXiong
Copy link
Contributor Author

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 19.41%. Comparing base (4cb18f5) to head (0c7ac1c).
Report is 84 commits behind head on main.

Additional details and impacted files

@@             Coverage Diff             @@
##             main     #271       +/-   ##
===========================================
- Coverage   78.75%   19.41%   -59.35%     
===========================================
  Files          11       85       +74     
  Lines         193     3699     +3506     
  Branches       73      753      +680     
===========================================
+ Hits          152      718      +566     
- Misses         11     2912     +2901     
- Partials       30       69       +39

Flag Coverage Δ
differential 19.41% <ø> (?)
total ?
☔ View full report in Codecov by Sentry. 📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

Something is wrong with test coverage statistics. Test coverage should refer here.

xmfcx
xmfcx requested changes Mar 13, 2025
View reviewed changes
Copy link
Contributor

@xmfcx xmfcx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://results.pre-commit.ci/run/github/429652448/1741831258.ks5FnNQ1SOqQxNYV8fA1FA

pre-commit is failing

@NorahXiong NorahXiong force-pushed the ut/autoware_vehicle_info_utils branch from 2226462 to e5c4000 Compare March 14, 2025 01:14
@NorahXiong
Copy link
Contributor Author

https://results.pre-commit.ci/run/github/429652448/1741831258.ks5FnNQ1SOqQxNYV8fA1FA

pre-commit is failing

Thks. Fixed now.

youtalk
youtalk approved these changes Mar 18, 2025
View reviewed changes
Copy link
Member

@youtalk youtalk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@youtalk youtalk requested a review from xmfcx March 18, 2025 00:08
@youtalk youtalk enabled auto-merge (squash) March 18, 2025 00:08
@youtalk
Copy link
Member

youtalk commented Mar 25, 2025

@xmfcx @JianKangEgon @soblin @shmpwk @taikitanaka3 @tkimura4 Please review this.

shmpwk
shmpwk approved these changes Mar 25, 2025
View reviewed changes
Copy link
Contributor

@shmpwk shmpwk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tkimura4 tkimura4 disabled auto-merge March 25, 2025 05:27
@NorahXiong NorahXiong force-pushed the ut/autoware_vehicle_info_utils branch from 4da6455 to 2a19ff1 Compare March 25, 2025 06:19
NorahXiong and others added 4 commits March 25, 2025 14:24
@NorahXiong
test(autoware_vehicle_info_utils): add tests for missed lines
5e6d0a3 
Signed-off-by: NorahXiong <norah.xiong@autocore.ai>
@pre-commit-ci @NorahXiong
style(pre-commit): autofix
b808b43
@NorahXiong
test(autoware_planning_test_manager): fix cpplint error
701f036 
Signed-off-by: NorahXiong <norah.xiong@autocore.ai>
@NorahXiong
fix(autoware_vehicle_info_utils): fix division by zero operation logic
20b2e40 
Signed-off-by: NorahXiong <norah.xiong@autocore.ai>
@NorahXiong NorahXiong force-pushed the ut/autoware_vehicle_info_utils branch from a650691 to 7f7e530 Compare March 25, 2025 06:24
@NorahXiong NorahXiong marked this pull request as draft March 25, 2025 06:26
@NorahXiong NorahXiong force-pushed the ut/autoware_vehicle_info_utils branch from 7f7e530 to 10f04d1 Compare March 25, 2025 06:31
@NorahXiong NorahXiong marked this pull request as ready for review March 25, 2025 06:41
@NorahXiong
Copy link
Contributor Author

@tkimura4 @sasakisasaki Fixing code added, please review again.

tkimura4
tkimura4 approved these changes Mar 25, 2025
View reviewed changes
Copy link

@tkimura4 tkimura4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

sasakisasaki
sasakisasaki approved these changes Mar 25, 2025
View reviewed changes
Copy link
Contributor

@sasakisasaki sasakisasaki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reason for Approval

I understand the contents of changed parts in the discussion above 👍

@youtalk
Copy link
Member

youtalk commented Mar 26, 2025

@xmfcx Please update your review.

@soblin soblin merged commit 95daae8 into autowarefoundation:main Mar 26, 2025
19 of 20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@youtalk youtalk

@xmfcx xmfcx

@sasakisasaki sasakisasaki

@soblin soblin

@shmpwk shmpwk

@tkimura4 tkimura4

@JianKangEgon JianKangEgon

@taikitanaka3 taikitanaka3

@mitsudome-r mitsudome-r

Assignees
No one assigned
Labels
run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@NorahXiong @youtalk @xmfcx @sasakisasaki @soblin @shmpwk @tkimura4