-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test(path_generator): add tests for turn signal activation feature #253
test(path_generator): add tests for turn signal activation feature #253
Conversation
Thank you for contributing to the Autoware project! 🚧 If your pull request is in progress, switch it to draft mode. Please ensure:
|
Co-authored-by: Kosuke Takeuchi <kosuke.tnp@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #253 +/- ##
===========================================
- Coverage 78.75% 19.27% -59.48%
===========================================
Files 11 94 +83
Lines 193 4233 +4040
Branches 73 880 +807
===========================================
+ Hits 152 816 +664
- Misses 11 3313 +3302
- Partials 30 104 +74
☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
@autowarefoundation/autoware-core-global-codeowners @kosuke55 Please review this. |
I will check |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
const auto result = utils::get_turn_signal_required_end_point( | ||
planner_data_.lanelet_map_ptr->laneletLayer.get(lane_id), angle_threshold_deg); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oh, I wanted to add position check but mistakenly approved and merged..
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
send PR #323
Description
This PR adds tests for turn signal activation feature of
path_generator
.How was this PR tested?
gives the following result (excerpt):
Notes for reviewers
None.
Interface changes
None.
Effects on system behavior
None.