Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(autoware_geography_utils): add support for local cartesian projection #181

Merged
merged 8 commits into from
Feb 25, 2025

Conversation

sebekx
Copy link
Contributor

@sebekx sebekx commented Feb 5, 2025

Add LocalCaretsian (WGS84) projection support to map_loader.

Description

Related links

How was this PR tested?

Notes for reviewers

None.

Interface changes

None.

Effects on system behavior

None.

Copy link

github-actions bot commented Feb 5, 2025

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

@TaikiYamada4
Copy link

@mitsudome-r

I'm not sure about how strict reviewers should be to PRs to autoware.core, but is this acceptable?
(The content seems fine to me.)

@xmfcx
Copy link
Contributor

xmfcx commented Feb 25, 2025

I'm not sure about how strict reviewers should be to PRs to autoware.core, but is this acceptable?

For now, you may proceed with a similar care that you give for Autoware Universe.
@TaikiYamada4

@xmfcx xmfcx added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Feb 25, 2025
@xmfcx xmfcx requested a review from TaikiYamada4 February 25, 2025 02:49
@xmfcx xmfcx force-pushed the feat/autoware_geography_utils branch from 49bf739 to 08d902d Compare February 25, 2025 02:52
@xmfcx xmfcx changed the title feat(autoware_geography_utils): add support for local cartesian proje… feat(autoware_geography_utils): add support for local cartesian projection Feb 25, 2025
Copy link

codecov bot commented Feb 25, 2025

Codecov Report

Attention: Patch coverage is 82.92683% with 7 lines in your changes missing coverage. Please review.

Project coverage is 40.62%. Comparing base (4cb18f5) to head (b4006bc).
Report is 51 commits behind head on main.

Files with missing lines Patch % Lines
.../autoware_geography_utils/test/test_projection.cpp 77.77% 0 Missing and 6 partials ⚠️
...e_geography_utils/test/test_lanelet2_projector.cpp 87.50% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main     #181       +/-   ##
===========================================
- Coverage   78.75%   40.62%   -38.14%     
===========================================
  Files          11        8        -3     
  Lines         193      416      +223     
  Branches       73       84       +11     
===========================================
+ Hits          152      169       +17     
- Misses         11      216      +205     
- Partials       30       31        +1     
Flag Coverage Δ
differential 40.62% <82.92%> (?)
total ?

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@youtalk youtalk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@xmfcx xmfcx marked this pull request as draft February 25, 2025 06:22
Sebastian Zęderowski and others added 5 commits February 25, 2025 15:29
…ction

Signed-off-by: Sebastian Zęderowski <szederowski@autonomous-systems.pl>
…ction

Signed-off-by: Sebastian Zęderowski <szederowski@autonomous-systems.pl>
…ction

Signed-off-by: Sebastian Zęderowski <szederowski@autonomous-systems.pl>
Signed-off-by: Mete Fatih Cırıt <mfc@autoware.org>
@xmfcx xmfcx force-pushed the feat/autoware_geography_utils branch from 5ddb339 to f9ef4cc Compare February 25, 2025 06:29
Signed-off-by: Mete Fatih Cırıt <mfc@autoware.org>
@xmfcx
Copy link
Contributor

xmfcx commented Feb 25, 2025

@youtalk -san, I've added the tests with f9ef4cc 👍

It is very similar to local cartesian utm after all.

@xmfcx xmfcx marked this pull request as ready for review February 25, 2025 06:55
Copy link
Member

@youtalk youtalk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've fixed my suggestion by myself. Then LGTM.
0a4b936

@youtalk
Copy link
Member

youtalk commented Feb 25, 2025

@TaikiYamada4 Please review again.

Copy link

@TaikiYamada4 TaikiYamada4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm also good with the changes but the pre-commit-optional is failing due to other PRs.

It will be fixed in here (#221) so this could be merged after it.

@youtalk
Copy link
Member

youtalk commented Feb 25, 2025

I fixed it in #222.

@youtalk youtalk enabled auto-merge (squash) February 25, 2025 11:11
@youtalk youtalk disabled auto-merge February 25, 2025 11:11
@youtalk youtalk merged commit 08c74b8 into autowarefoundation:main Feb 25, 2025
25 of 26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants