-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(autoware_geography_utils): add support for local cartesian projection #181
feat(autoware_geography_utils): add support for local cartesian projection #181
Conversation
Thank you for contributing to the Autoware project! 🚧 If your pull request is in progress, switch it to draft mode. Please ensure:
|
I'm not sure about how strict reviewers should be to PRs to autoware.core, but is this acceptable? |
For now, you may proceed with a similar care that you give for Autoware Universe. |
49bf739
to
08d902d
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #181 +/- ##
===========================================
- Coverage 78.75% 40.62% -38.14%
===========================================
Files 11 8 -3
Lines 193 416 +223
Branches 73 84 +11
===========================================
+ Hits 152 169 +17
- Misses 11 216 +205
- Partials 30 31 +1
☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
…ction Signed-off-by: Sebastian Zęderowski <szederowski@autonomous-systems.pl>
…ction Signed-off-by: Sebastian Zęderowski <szederowski@autonomous-systems.pl>
…ction Signed-off-by: Sebastian Zęderowski <szederowski@autonomous-systems.pl>
5ddb339
to
f9ef4cc
Compare
Signed-off-by: Mete Fatih Cırıt <mfc@autoware.org>
common/autoware_geography_utils/test/test_lanelet2_projector.cpp
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've fixed my suggestion by myself. Then LGTM.
0a4b936
@TaikiYamada4 Please review again. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm also good with the changes but the pre-commit-optional is failing due to other PRs.
It will be fixed in here (#221) so this could be merged after it.
|
Add LocalCaretsian (WGS84) projection support to map_loader.
Description
Related links
How was this PR tested?
Notes for reviewers
None.
Interface changes
None.
Effects on system behavior
None.