Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(autoware.repos): bumped the cuda_blackboard's version to 0.2.0 #5924

Merged
merged 2 commits into from
Mar 24, 2025

Conversation

knzo25
Copy link
Contributor

@knzo25 knzo25 commented Mar 24, 2025

Description

In the cuda_blackboard subscribers needed to configure whether they need or not a compatible subscriber (a default ROS message), causing confusion as to when that was necessary. In the v0.2.0 release, the compatible subscriber is added by default and disconnected automatically once a negotiated (a cuda blackboard) publisher is detected.

How was this PR tested?

Tested locally using the logging simulator with the PRs from autowarefoundation/autoware_universe#9722

Notes for reviewers

This PR does not make an impact in the current autoware.
However, it is required to address the feedback received in autowarefoundation/autoware_universe#9453

Effects on system behavior

Nodes using the cuda_blackboard will be able to automatically disconnect to the compatible subscriber once a negotiated subscriber message is received.

Signed-off-by: Kenzo Lobos-Tsunekawa <kenzo.lobos@tier4.jp>
Copy link

github-actions bot commented Mar 24, 2025

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

@knzo25
Copy link
Contributor Author

knzo25 commented Mar 24, 2025

@sasakisasaki
The CI/CD seems to be failing due to autoware_perception_online_evaluator
Could it be related to this PR? autowarefoundation/autoware_universe#9956

@knzo25 knzo25 self-assigned this Mar 24, 2025
@sasakisasaki
Copy link
Collaborator

@knzo25 Thank you for sharing the information! Let me check.

@sasakisasaki
Copy link
Collaborator

@knzo25 It seems the issue looks under fix in this PR. Hopefully this answers to your question. Thank you in advance!

@knzo25
Copy link
Contributor Author

knzo25 commented Mar 24, 2025

@sasakisasaki Thanks !

Copy link
Contributor

@xmfcx xmfcx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

health-check-nightly has failed for an unrelated reason.
https://github.com/autowarefoundation/autoware/actions/runs/14028342321/job/39270873535?pr=5924

The health-check has passed.

Since autoware builds with it, it's alright to merge 👍

@knzo25 is responsible from this package and its autoware.universe counterpart so he will make sure it works well.

@xmfcx xmfcx merged commit de99241 into autowarefoundation:main Mar 24, 2025
16 of 18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tag:run-health-check Run health-check
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants