Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: revert "use require-label action for health-check" #5845

Merged
merged 1 commit into from
Mar 6, 2025

Conversation

youtalk
Copy link
Member

@youtalk youtalk commented Mar 6, 2025

Reverts #5771

The health-check workflow triggered by the schedule and workflow_dispatch events is now always failing.
https://github.com/autowarefoundation/autoware/actions/runs/13675622013

I tried some correction methods, but it still isn’t working well. So I revert it for now and submit a fix PR later.

@youtalk youtalk requested review from xmfcx and mitsudome-r March 6, 2025 01:39
@youtalk youtalk self-assigned this Mar 6, 2025
Copy link

github-actions bot commented Mar 6, 2025

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

@youtalk youtalk added type:github-actions Github actions related. (auto-assigned) tag:run-health-check Run health-check labels Mar 6, 2025
@youtalk youtalk marked this pull request as ready for review March 6, 2025 01:40
@youtalk youtalk requested a review from oguzkaganozt as a code owner March 6, 2025 01:40
@youtalk
Copy link
Member Author

youtalk commented Mar 6, 2025

@mitsudome-r @xmfcx To merge this, we need to remove the require-label from the required check.

@xmfcx
Copy link
Contributor

xmfcx commented Mar 6, 2025

We were only using these for workflows triggered by the PR events and on differential workflows. So it's expected this should fail on schedule and workflow_dispatch triggers. I'll remove the requirement and merge it 👍

@xmfcx xmfcx merged commit 05037bf into main Mar 6, 2025
33 checks passed
@xmfcx xmfcx deleted the revert-5771-fix-health-check-ci branch March 6, 2025 05:08
@xmfcx
Copy link
Contributor

xmfcx commented Mar 6, 2025

We should add the correct checking mechanism so the require-label only activates for the pull request targets.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tag:run-health-check Run health-check type:github-actions Github actions related. (auto-assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants