Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(autoware.repos): added the cuda_blackboard and negotiated to the repos file #5710

Merged
merged 9 commits into from
Mar 18, 2025

Conversation

knzo25
Copy link
Contributor

@knzo25 knzo25 commented Jan 30, 2025

Description

This PR adds the cuda_blackboard and its dependency to the .repos file.
The cuda_blackboard provides a way to use device memory between nodes in a container without it leaving the GPU.

This PR is required for
autowarefoundation/autoware_universe#9722

How was this PR tested?

Run autoware with the PRs from the before mentioned issue

Notes for reviewers

None.

Effects on system behavior

None.

Signed-off-by: Kenzo Lobos-Tsunekawa <kenzo.lobos@tier4.jp>
Copy link

github-actions bot commented Jan 30, 2025

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

Signed-off-by: Kenzo Lobos-Tsunekawa <kenzo.lobos@tier4.jp>
Signed-off-by: Kenzo Lobos-Tsunekawa <kenzo.lobos@tier4.jp>
@knzo25
Copy link
Contributor Author

knzo25 commented Jan 30, 2025

Will turn this into draft once I check the status of CI/CD pending on cuda_blackboard release strategy and the LICENSE file

@knzo25 knzo25 self-assigned this Jan 30, 2025
@knzo25 knzo25 marked this pull request as draft January 30, 2025 03:05
@knzo25 knzo25 marked this pull request as ready for review March 17, 2025 06:30
knzo25 added 2 commits March 17, 2025 15:35
Signed-off-by: Kenzo Lobos-Tsunekawa <kenzo.lobos@tier4.jp>
@knzo25
Copy link
Contributor Author

knzo25 commented Mar 17, 2025

@mitsudome-r @xmfcx
As indicated in the parent issue, this PR is needed to avoid device->host->device copies.
One of the accepted PRs of the issue this this one in order to pass CI/CD:
autowarefoundation/autoware_universe#9454

My own concern though is that the other package I am adding: negotiated, while being from the osrf does not have releases nor has been touched in a while. What I think we could do:

  • Add as is, since there will be no updates in all probability
  • Add as is for now, ask them to make a release we can keep fixed
  • Fork in the awf and create a release

Do you have any preference? Thanks !

@knzo25 knzo25 added the tag:run-health-check Run health-check label Mar 17, 2025
@mitsudome-r
Copy link
Member

My own concern though is that the other package I am adding: negotiated, while being from the osrf does not have releases nor has been touched in a while.

Could you create an issue in their repo and ask what are their thoughts on maintaining the repository?
It seems like the repo is meant to be PoC in the first place, so there could be some other packages that are meant to be for actual use.

Also, if we are adding as is, I rather would like to use a tag or commit hash for autoware.repos file to make sure that we won't have build failure due to update in their branch.

Signed-off-by: Kenzo Lobos-Tsunekawa <kenzo.lobos@tier4.jp>
@knzo25
Copy link
Contributor Author

knzo25 commented Mar 18, 2025

@mitsudome-r
Sent the issue in osrf/negotiated#4
Although it looks very PoC, it is actually used by NVIDIA in Isaac ROS 😅
https://forums.developer.nvidia.com/t/apt-install-ros-humble-negotiated-error/274317

@knzo25 knzo25 requested a review from xmfcx March 18, 2025 02:25
@xmfcx xmfcx merged commit 87c29d4 into autowarefoundation:main Mar 18, 2025
17 of 18 checks passed
sykwer pushed a commit to sykwer/autoware that referenced this pull request Mar 22, 2025
… repos file (autowarefoundation#5710)

Signed-off-by: Kenzo Lobos-Tsunekawa <kenzo.lobos@tier4.jp>
Signed-off-by: sykwer <sykwer@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tag:run-health-check Run health-check
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants