Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(tensorrt_yolo): remove package #4160

Merged

Conversation

kminoda
Copy link
Contributor

@kminoda kminoda commented Feb 8, 2024

Description

Part of:

See:

Tests performed

Not applicable

Effects on system behavior

Not applicable

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: kminoda <koji.minoda@tier4.jp>
Copy link

@miursh miursh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@miursh miursh requested a review from xmfcx February 8, 2024 13:46
@xmfcx
Copy link
Contributor

xmfcx commented Feb 9, 2024

Could you also update the README and sha checksum list?

Like here:

@kminoda
Copy link
Contributor Author

kminoda commented Feb 9, 2024

@xmfcx Thank you. Fixed: a4cb71a

@xmfcx
Copy link
Contributor

xmfcx commented Feb 9, 2024

Thanks, we can merge this after:

@miursh
Copy link

miursh commented Feb 11, 2024

@xmfcx
Since autowarefoundation/autoware.universe#6361 has been merged, could you please merge this PR?
It looks like I don't have the authority to merge this.

@xmfcx xmfcx merged commit 108c7bb into autowarefoundation:main Feb 11, 2024
16 checks passed
oguzkaganozt pushed a commit that referenced this pull request Feb 19, 2024
Signed-off-by: kminoda <koji.minoda@tier4.jp>
Signed-off-by: Oguz Ozturk <oguzkaganozt@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants