Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add build-and-test-packages-above-differential.yaml and packages_above.repos #9854

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

takayuki5168
Copy link
Contributor

@takayuki5168 takayuki5168 commented Jan 8, 2025

Description

Since the CI on the autoware.universe's PR does not check the build of above dependencies, the autoware_tools which depends on the autoware.universe is sometimes broken by the autoware.universe's change.
To avoid this, this PR introduced packages_above.repos and added a new workflow with packages_above.repos.

Related links

How was this PR tested?

With autowarefoundation/autoware-github-actions#333, the test's results are as expected as follows

Notes for reviewers

None.

Interface changes

None.

Effects on system behavior

None.

@github-actions github-actions bot added the type:ci Continuous Integration (CI) processes and testing. (auto-assigned) label Jan 8, 2025
Copy link

github-actions bot commented Jan 8, 2025

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

@takayuki5168 takayuki5168 force-pushed the feat/build-above-dependency2 branch from 67395c4 to 0f795c2 Compare January 8, 2025 02:29
@takayuki5168 takayuki5168 marked this pull request as ready for review January 8, 2025 02:37
@takayuki5168 takayuki5168 added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Jan 9, 2025
@mitsudome-r
Copy link
Member

This PR runs colcon build with packages_above.repos as a separate job from build-test-tidy-pr so there will be duplicate work to build all the packages within build_depends.repos and autoware.universe again in this job. Maybe we can consider using cache from build-test-tidy-pr job for more efficiency in the future, but I'm okay to define it as a independent job for easier maintenance.

@mitsudome-r
Copy link
Member

It might also require modification of build-test-tidy-pr and call this workflow as additional job to trigger the workflow.

@mitsudome-r
Copy link
Member

mitsudome-r commented Mar 10, 2025

  1. Reflect recent modification to build-and-test-differential.yaml (such as prepare build_depend.repos) to your workflow.

  2. Please update built-and-test-pr.yaml to add a new job "build-and-test-differentail-above" with the following content to run your workflow against PRs:

    if: ${{ always() }}
    needs:
      - require-label
    uses: ./.github/workflows/build-and-test-differential-above.yaml
    with:
      container: ghcr.io/autowarefoundation/autoware:universe-devel
      run-condition: ${{ needs.require-label.outputs.result == 'true' }}
    secrets:
      codecov-token: ${{ secrets.CODECOV_TOKEN }}
  1. Please run test with feat(colcon-build, colcon-test, clang-tidy): add packages-above-repos argument autoware-github-actions#333.
    You can specify the "feat/colcon-build-above-dependency" branch instead of v1 in this line: https://github.com/tier4/autoware.universe/blob/0f795c2b25d2cddcb02eb51c9592f29cb9639556/.github/workflows/build-and-test-packages-above-differential.yaml#L97

Once the test is confirmed we can merge both PRs.

…s_above.repos

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
@takayuki5168 takayuki5168 force-pushed the feat/build-above-dependency2 branch from 0f795c2 to d913177 Compare March 10, 2025 15:56
@takayuki5168
Copy link
Contributor Author

@mitsudome-r
I fixed for the comment 1-3. Additionally, since the change of the clang-tidy action is not necessary, I reverted it as follows.
autowarefoundation/autoware-github-actions@549dff4

And I tested the actions and the results are as expected. I described them in detail in the PR's description.

Now I'm ready to merge the PRs!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) type:ci Continuous Integration (CI) processes and testing. (auto-assigned)
Projects
Status: To Triage
Development

Successfully merging this pull request may close these issues.

2 participants