-
Notifications
You must be signed in to change notification settings - Fork 691
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add build-and-test-packages-above-differential.yaml and packages_above.repos #9854
base: main
Are you sure you want to change the base?
feat: add build-and-test-packages-above-differential.yaml and packages_above.repos #9854
Conversation
Thank you for contributing to the Autoware project! 🚧 If your pull request is in progress, switch it to draft mode. Please ensure:
|
67395c4
to
0f795c2
Compare
This PR runs colcon build with packages_above.repos as a separate job from build-test-tidy-pr so there will be duplicate work to build all the packages within build_depends.repos and autoware.universe again in this job. Maybe we can consider using cache from build-test-tidy-pr job for more efficiency in the future, but I'm okay to define it as a independent job for easier maintenance. |
It might also require modification of build-test-tidy-pr and call this workflow as additional job to trigger the workflow. |
Once the test is confirmed we can merge both PRs. |
…s_above.repos Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
0f795c2
to
d913177
Compare
@mitsudome-r And I tested the actions and the results are as expected. I described them in detail in the PR's description. Now I'm ready to merge the PRs! |
Description
Since the CI on the autoware.universe's PR does not check the build of above dependencies, the autoware_tools which depends on the autoware.universe is sometimes broken by the autoware.universe's change.
To avoid this, this PR introduced
packages_above.repos
and added a new workflow withpackages_above.repos
.Related links
How was this PR tested?
With autowarefoundation/autoware-github-actions#333, the test's results are as expected as follows
Notes for reviewers
None.
Interface changes
None.
Effects on system behavior
None.