-
Notifications
You must be signed in to change notification settings - Fork 691
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(autoware_multi_object_tracker): add default values on the schema json #8179
docs(autoware_multi_object_tracker): add default values on the schema json #8179
Conversation
Thank you for contributing to the Autoware project! 🚧 If your pull request is in progress, switch it to draft mode. Please ensure:
|
@technolojin I think this is caused by some parameters in schema files are lack of certain default values, I have updated the schema files. On github, it says that this branch has conflicting files "perception/multi_object_tracker/README.md", but I can't see any conflicts after I updated my local branch and merged main into this branch. |
@tby-udel |
@tby-udel We had to rename all the package names to have prefix Your current branch contains 212 commits and those are by merging the main to your branch. |
… file. Signed-off-by: Boyang <tby@udel.edu>
0db6e47
to
d17104b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #8179 +/- ##
==========================================
+ Coverage 23.74% 23.76% +0.01%
==========================================
Files 1378 1379 +1
Lines 101354 101322 -32
Branches 38522 38503 -19
==========================================
+ Hits 24068 24076 +8
+ Misses 74870 74766 -104
- Partials 2416 2480 +64
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. |
… json (autowarefoundation#8179) * Refractored the parameters, build the schema file, updated the readme file. Signed-off-by: Boyang <tby@udel.edu> * style(pre-commit): autofix --------- Signed-off-by: Boyang <tby@udel.edu> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
… json (autowarefoundation#8179) * Refractored the parameters, build the schema file, updated the readme file. Signed-off-by: Boyang <tby@udel.edu> * style(pre-commit): autofix --------- Signed-off-by: Boyang <tby@udel.edu> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
the error persists schema/input_channels.schema.json still missing the default values fix PR #8473 |
… json (autowarefoundation#8179) * Refractored the parameters, build the schema file, updated the readme file. Signed-off-by: Boyang <tby@udel.edu> * style(pre-commit): autofix --------- Signed-off-by: Boyang <tby@udel.edu> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Signed-off-by: xtk8532704 <1041084556@qq.com>
Description
Fixing the #7333 issue of the
multi_object_tracker
package.Tests performed
Package built and launched locally.
Notes for reviewers
Nothing inside the src code part was changed, only updating schema file.
Interface changes
Parameter values are now required to be passed to the node when launched.
Effects on system behavior
None
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.