-
Notifications
You must be signed in to change notification settings - Fork 691
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(autoware_lidar_centerpoint): updated tests #8158
chore(autoware_lidar_centerpoint): updated tests #8158
Conversation
… they were not compiling (forgot to update them when I added the new cloud capacity parameter) Signed-off-by: Kenzo Lobos-Tsunekawa <kenzo.lobos@tier4.jp>
Thank you for contributing to the Autoware project! 🚧 If your pull request is in progress, switch it to draft mode. Please ensure:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
confirmed that the test passes locally w/ these tests enabled
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #8158 +/- ##
==========================================
+ Coverage 29.21% 29.26% +0.04%
==========================================
Files 1600 1601 +1
Lines 117718 117648 -70
Branches 50696 50701 +5
==========================================
+ Hits 34397 34425 +28
+ Misses 74109 73979 -130
- Partials 9212 9244 +32
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. |
…8158) chore: updated centerpoin tests. they are currently commented out but they were not compiling (forgot to update them when I added the new cloud capacity parameter) Signed-off-by: Kenzo Lobos-Tsunekawa <kenzo.lobos@tier4.jp>
…8158) chore: updated centerpoin tests. they are currently commented out but they were not compiling (forgot to update them when I added the new cloud capacity parameter) Signed-off-by: Kenzo Lobos-Tsunekawa <kenzo.lobos@tier4.jp>
…8158) chore: updated centerpoin tests. they are currently commented out but they were not compiling (forgot to update them when I added the new cloud capacity parameter) Signed-off-by: Kenzo Lobos-Tsunekawa <kenzo.lobos@tier4.jp>
Description
The cuda related tests are currently commented out, so when I added the new
cloud_capacity
parameter forgot to update the tests. This PR addresses it.Related links
How was this PR tested?
Notes for reviewers
None.
Interface changes
None.
Effects on system behavior
None.