Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(autoware_lidar_centerpoint): updated tests #8158

Merged
merged 2 commits into from
Jul 25, 2024

Conversation

knzo25
Copy link
Contributor

@knzo25 knzo25 commented Jul 23, 2024

Description

The cuda related tests are currently commented out, so when I added the new cloud_capacity parameter forgot to update the tests. This PR addresses it.

Related links

How was this PR tested?

Notes for reviewers

None.

Interface changes

None.

Effects on system behavior

None.

… they were not compiling (forgot to update them when I added the new cloud capacity parameter)

Signed-off-by: Kenzo Lobos-Tsunekawa <kenzo.lobos@tier4.jp>
@knzo25 knzo25 requested a review from kminoda as a code owner July 23, 2024 05:16
@github-actions github-actions bot added the component:perception Advanced sensor data processing and environment understanding. (auto-assigned) label Jul 23, 2024
Copy link

github-actions bot commented Jul 23, 2024

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

Copy link
Contributor

@kminoda kminoda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
confirmed that the test passes locally w/ these tests enabled

@knzo25 knzo25 added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Jul 25, 2024
@knzo25 knzo25 enabled auto-merge (squash) July 25, 2024 07:48
Copy link

codecov bot commented Jul 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 29.26%. Comparing base (3e496cc) to head (c29a57b).
Report is 618 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8158      +/-   ##
==========================================
+ Coverage   29.21%   29.26%   +0.04%     
==========================================
  Files        1600     1601       +1     
  Lines      117718   117648      -70     
  Branches    50696    50701       +5     
==========================================
+ Hits        34397    34425      +28     
+ Misses      74109    73979     -130     
- Partials     9212     9244      +32     
Flag Coverage Δ *Carryforward flag
differential 8.79% <ø> (?)
total 29.26% <ø> (+0.04%) ⬆️ Carriedforward from 4ef61d7

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@knzo25 knzo25 merged commit 9dacd1e into autowarefoundation:main Jul 25, 2024
30 checks passed
chihungtzeng pushed a commit to chihungtzeng/autoware.universe that referenced this pull request Jul 26, 2024
…8158)

chore: updated centerpoin tests. they are currently commented out but they were not compiling (forgot to update them when I added the new cloud capacity parameter)

Signed-off-by: Kenzo Lobos-Tsunekawa <kenzo.lobos@tier4.jp>
a-maumau pushed a commit to a-maumau/autoware.universe that referenced this pull request Jul 28, 2024
…8158)

chore: updated centerpoin tests. they are currently commented out but they were not compiling (forgot to update them when I added the new cloud capacity parameter)

Signed-off-by: Kenzo Lobos-Tsunekawa <kenzo.lobos@tier4.jp>
esteve pushed a commit to esteve/autoware.universe that referenced this pull request Aug 13, 2024
…8158)

chore: updated centerpoin tests. they are currently commented out but they were not compiling (forgot to update them when I added the new cloud capacity parameter)

Signed-off-by: Kenzo Lobos-Tsunekawa <kenzo.lobos@tier4.jp>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:perception Advanced sensor data processing and environment understanding. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) tag:require-cuda-build-and-test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants