Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(autoware_freespace_planning_algorithms): fix shadowVariable #7949

Merged

Conversation

kobayu858
Copy link
Contributor

Description

This is a fix based on cppcheck shadowVariable warnings

planning/autoware_freespace_planning_algorithms/src/astar_search.cpp:308:37: style: Local variable 'pose' shadows outer variable [shadowVariable]
    geometry_msgs::msg::PoseStamped pose;
                                    ^

planning/autoware_freespace_planning_algorithms/src/astar_search.cpp:313:21: style: Local variable 'pw' shadows outer variable [shadowVariable]
    PlannerWaypoint pw;
                    ^

planning/autoware_freespace_planning_algorithms/src/rrtstar_core.cpp:186:19: style: Local variable 'node_best_parent' shadows outer variable [shadowVariable]
    NodeSharedPtr node_best_parent;
                  ^

Related links

Parent Issue:

  • Link

How was this PR tested?

Notes for reviewers

None.

Interface changes

None.

Effects on system behavior

None.

Signed-off-by: kobayu858 <yutaro.kobayashi@tier4.jp>
@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label Jul 10, 2024
Copy link

github-actions bot commented Jul 10, 2024

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

@kobayu858 kobayu858 requested a review from veqcc July 10, 2024 11:14
@kobayu858 kobayu858 added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Jul 10, 2024
Copy link

codecov bot commented Jul 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 28.75%. Comparing base (6b9f164) to head (230a976).
Report is 46 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #7949   +/-   ##
=======================================
  Coverage   28.75%   28.75%           
=======================================
  Files        1594     1600    +6     
  Lines      116894   116885    -9     
  Branches    50048    50048           
=======================================
  Hits        33615    33615           
- Misses      74154    74172   +18     
+ Partials     9125     9098   -27     
Flag Coverage Δ *Carryforward flag
differential 15.42% <100.00%> (?)
total 28.76% <ø> (+<0.01%) ⬆️ Carriedforward from 8bf0622

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: kobayu858 <yutaro.kobayashi@tier4.jp>
Signed-off-by: kobayu858 <yutaro.kobayashi@tier4.jp>
@kobayu858 kobayu858 requested a review from veqcc July 12, 2024 04:43
@kobayu858
Copy link
Contributor Author

@kosuke55 @TakaHoribe @takayuki5168

Please confirm the PR. Thank you very much.

@kosuke55 kosuke55 merged commit 35d6465 into autowarefoundation:main Jul 22, 2024
30 checks passed
@kobayu858
Copy link
Contributor Author

Thanks for the merge.

chihungtzeng pushed a commit to chihungtzeng/autoware.universe that referenced this pull request Jul 23, 2024
…warefoundation#7949)

* fix:shadowVariable

Signed-off-by: kobayu858 <yutaro.kobayashi@tier4.jp>

* fix:shadowVariable

Signed-off-by: kobayu858 <yutaro.kobayashi@tier4.jp>

* fix:shadowVariable

Signed-off-by: kobayu858 <yutaro.kobayashi@tier4.jp>

---------

Signed-off-by: kobayu858 <yutaro.kobayashi@tier4.jp>
@kobayu858 kobayu858 deleted the fix/cppcheck_shadowVariable_pla-1 branch July 23, 2024 01:13
kyoichi-sugahara pushed a commit to kyoichi-sugahara/autoware.universe that referenced this pull request Jul 23, 2024
…warefoundation#7949)

* fix:shadowVariable

Signed-off-by: kobayu858 <yutaro.kobayashi@tier4.jp>

* fix:shadowVariable

Signed-off-by: kobayu858 <yutaro.kobayashi@tier4.jp>

* fix:shadowVariable

Signed-off-by: kobayu858 <yutaro.kobayashi@tier4.jp>

---------

Signed-off-by: kobayu858 <yutaro.kobayashi@tier4.jp>
zulfaqar-azmi-t4 pushed a commit to zulfaqar-azmi-t4/autoware.universe that referenced this pull request Jul 23, 2024
…warefoundation#7949)

* fix:shadowVariable

Signed-off-by: kobayu858 <yutaro.kobayashi@tier4.jp>

* fix:shadowVariable

Signed-off-by: kobayu858 <yutaro.kobayashi@tier4.jp>

* fix:shadowVariable

Signed-off-by: kobayu858 <yutaro.kobayashi@tier4.jp>

---------

Signed-off-by: kobayu858 <yutaro.kobayashi@tier4.jp>
esteve pushed a commit to esteve/autoware.universe that referenced this pull request Aug 13, 2024
…warefoundation#7949)

* fix:shadowVariable

Signed-off-by: kobayu858 <yutaro.kobayashi@tier4.jp>

* fix:shadowVariable

Signed-off-by: kobayu858 <yutaro.kobayashi@tier4.jp>

* fix:shadowVariable

Signed-off-by: kobayu858 <yutaro.kobayashi@tier4.jp>

---------

Signed-off-by: kobayu858 <yutaro.kobayashi@tier4.jp>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants