-
Notifications
You must be signed in to change notification settings - Fork 691
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(probabilistic_occupancy_grid_map): fix shadowVariable #7942
fix(probabilistic_occupancy_grid_map): fix shadowVariable #7942
Conversation
Signed-off-by: kobayu858 <yutaro.kobayashi@tier4.jp>
Signed-off-by: kobayu858 <yutaro.kobayashi@tier4.jp>
Thank you for contributing to the Autoware project! 🚧 If your pull request is in progress, switch it to draft mode. Please ensure:
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #7942 +/- ##
==========================================
+ Coverage 28.75% 28.76% +0.01%
==========================================
Files 1594 1594
Lines 116894 116850 -44
Branches 50048 50051 +3
==========================================
+ Hits 33615 33616 +1
+ Misses 74154 74137 -17
+ Partials 9125 9097 -28
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. |
perception/probabilistic_occupancy_grid_map/lib/costmap_2d/occupancy_grid_map_fixed.cpp
Outdated
Show resolved
Hide resolved
Signed-off-by: kobayu858 <yutaro.kobayashi@tier4.jp>
perception/probabilistic_occupancy_grid_map/lib/costmap_2d/occupancy_grid_map_projective.cpp
Outdated
Show resolved
Hide resolved
Signed-off-by: kobayu858 <yutaro.kobayashi@tier4.jp>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…undation#7942) * fix:shadowVariable Signed-off-by: kobayu858 <yutaro.kobayashi@tier4.jp> * refactor: use range-based for loop Signed-off-by: kobayu858 <yutaro.kobayashi@tier4.jp> * style: rename variable Signed-off-by: kobayu858 <yutaro.kobayashi@tier4.jp> * style: rename variable Signed-off-by: kobayu858 <yutaro.kobayashi@tier4.jp> --------- Signed-off-by: kobayu858 <yutaro.kobayashi@tier4.jp>
Description
This is a fix based on cppcheck shadowVariable warnings
Using range-based for loop.
Related links
Parent Issue:
How was this PR tested?
Notes for reviewers
None.
Interface changes
None.
Effects on system behavior
None.