Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ml detector buffer capacity and parameterization #7936

Merged
merged 6 commits into from
Jul 17, 2024

Merge branch 'main' into fix/centerpoint_buffer

83e6a6b
Select commit
Loading
Failed to load commit list.
Merged

fix: ml detector buffer capacity and parameterization #7936

Merge branch 'main' into fix/centerpoint_buffer
83e6a6b
Select commit
Loading
Failed to load commit list.
CodeScene Delta Analysis / CodeScene Cloud Delta Analysis (main) succeeded Jul 17, 2024 in 35s

CodeScene PR Check

Code Health Quality Gates: OK

Change in average Code Health of affected files: -0.00 (9.49 -> 9.48)

  • Declining Code Health: 2 findings(s) 🚩

View detailed results in CodeScene

Details

🚩 Declining Code Health (highest to lowest):

  • Large Method node.cpp: LidarCenterPointNode::LidarCenterPointNode
  • Large Method lidar_transfusion_node.cpp: LidarTransfusionNode::LidarTransfusionNode

Annotations

Check warning on line 110 in perception/lidar_centerpoint/src/node.cpp

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)

❌ Getting worse: Large Method

LidarCenterPointNode::LidarCenterPointNode increases from 89 to 90 lines of code, threshold = 70. Large functions with many lines of code are generally harder to understand and lower the code health. Avoid adding more lines to this function.

Check warning on line 81 in perception/lidar_transfusion/src/lidar_transfusion_node.cpp

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)

❌ Getting worse: Large Method

LidarTransfusionNode::LidarTransfusionNode increases from 78 to 81 lines of code, threshold = 70. Large functions with many lines of code are generally harder to understand and lower the code health. Avoid adding more lines to this function.