feat(out_of_lane): also apply lat buffer between the lane and stop pose #7918
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maxime-clem
added
the
run:build-and-test-differential
maxime-clem
requested review from
shmpwk,
takayuki5168 and
tkimura4
as code owners
github-actions
bot
added
the
component:planning
|
Thank you for contributing to the Autoware project! 🚧 If your pull request is in progress, switch it to draft mode. Please ensure:
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #7918 +/- ##
==========================================
- Coverage 29.24% 29.20% -0.04%
==========================================
Files 1600 1604 +4
Lines 117738 117526 -212
Branches 50720 50657 -63
==========================================
- Hits 34427 34323 -104
+ Misses 74120 74020 -100
+ Partials 9191 9183 -8
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. |
maxime-clem
force-pushed
the
feat/out_of_lane-lat_buffer
branch
from
c6fb518 to
e3ebacb
Compare
Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp>
maxime-clem
force-pushed
the
feat/out_of_lane-lat_buffer
branch
from
e3ebacb to
6647f59
Compare
4 tasks
takayuki5168
approved these changes
Jul 30, 2024
maxime-clem
added a commit
to maxime-clem/autoware.universe
that referenced
this pull request
Jul 31, 2024
…se (autowarefoundation#7918) Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp>
shmpwk
pushed a commit
to tier4/autoware.universe
that referenced
this pull request
Aug 1, 2024
…se (#1438) feat(out_of_lane): also apply lat buffer between the lane and stop pose (autowarefoundation#7918) Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp>
esteve
pushed a commit
to esteve/autoware.universe
that referenced
this pull request
Aug 13, 2024
…se (autowarefoundation#7918) Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In the
out_of_lanemodule, the buffer distance to keep between the lane and the ego vehicle was only considering longitudinal distance. This PR also consider the lateral distance to properly keep the desired buffer distance.The following video shows the new impact of the buffer distance parameter. On the right I dynamically update the parameter value (from
0.0at first up to5.0m) and on the left you can see the distance increase between the stop point and the lane with the collision.simplescreenrecorder-2024-07-09_18.06.30.mp4
Requires autowarefoundation/autoware_launch#1098
Related links
How was this PR tested?
Psim
Notes for reviewers
None.
Interface changes
None.
Effects on system behavior
None.