Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(euclidean_cluster): include autoware_universe_utils headers #7908

Conversation

technolojin
Copy link
Contributor

@technolojin technolojin commented Jul 9, 2024

Description

StopWatch and DebugPublisher of 'autoware_universe_utils' were sourced indirectly via package 'compare_map_segmentation'. This PR fixes it for direct include.

Related links

How was this PR tested?

No logic changes. Build test is enough.

Notes for reviewers

None.

Interface changes

None.

Effects on system behavior

None.

@technolojin technolojin added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Jul 9, 2024
@github-actions github-actions bot added the component:perception Advanced sensor data processing and environment understanding. (auto-assigned) label Jul 9, 2024
Copy link

github-actions bot commented Jul 9, 2024

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

Copy link

codecov bot commented Jul 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 28.44%. Comparing base (6d0247e) to head (067449e).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7908      +/-   ##
==========================================
- Coverage   28.44%   28.44%   -0.01%     
==========================================
  Files        1591     1592       +1     
  Lines      116213   116228      +15     
  Branches    49613    49616       +3     
==========================================
  Hits        33059    33059              
- Misses      74141    74156      +15     
  Partials     9013     9013              
Flag Coverage Δ *Carryforward flag
differential 4.21% <ø> (?)
total 28.44% <ø> (ø) Carriedforward from 6d0247e

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

…egmentation package

Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp>
@technolojin technolojin force-pushed the fix/euclidean_cluster-dependency branch from f8cd306 to 067449e Compare July 9, 2024 05:38
@technolojin technolojin marked this pull request as ready for review July 9, 2024 05:39
@technolojin technolojin enabled auto-merge (squash) July 9, 2024 05:55
Copy link
Contributor

@badai-nguyen badai-nguyen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@technolojin technolojin merged commit f716b5b into autowarefoundation:main Jul 9, 2024
32 checks passed
@technolojin technolojin deleted the fix/euclidean_cluster-dependency branch July 9, 2024 06:19
palas21 pushed a commit to palas21/autoware.universe that referenced this pull request Jul 12, 2024
…warefoundation#7908)

fix: include autoware_universe_utils headers instead of compare_map_segmentation package

Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp>
Signed-off-by: palas21 <palas21@itu.edu.tr>
KhalilSelyan pushed a commit that referenced this pull request Jul 22, 2024
fix: include autoware_universe_utils headers instead of compare_map_segmentation package

Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp>
Ariiees pushed a commit to Ariiees/autoware.universe that referenced this pull request Jul 22, 2024
…warefoundation#7908)

fix: include autoware_universe_utils headers instead of compare_map_segmentation package

Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:perception Advanced sensor data processing and environment understanding. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants