-
Notifications
You must be signed in to change notification settings - Fork 691
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(autoware_universe_utils): update document #7907
chore(autoware_universe_utils): update document #7907
Conversation
Signed-off-by: Y.Hisaki <yhisaki31@gmail.com>
Thank you for contributing to the Autoware project! 🚧 If your pull request is in progress, switch it to draft mode. Please ensure:
|
Signed-off-by: Y.Hisaki <yhisaki31@gmail.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7907 +/- ##
=======================================
Coverage 28.94% 28.94%
=======================================
Files 1600 1601 +1
Lines 117232 117227 -5
Branches 50299 50297 -2
=======================================
+ Hits 33933 33935 +2
+ Misses 74150 74144 -6
+ Partials 9149 9148 -1
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Signed-off-by: Y.Hisaki <yhisaki31@gmail.com>
Signed-off-by: Y.Hisaki <yhisaki31@gmail.com>
#include <iostream> | ||
#include <memory> | ||
#include <thread> | ||
|
||
class TimeKeeperExample : public rclcpp::Node |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ExampleNode instead of TimeKeeperExample sounds better since the word TimeKeeper
is everywhere currently and searchability is not so high.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed!
Signed-off-by: Y.Hisaki <yhisaki31@gmail.com>
…to update-time_keeper-document
Signed-off-by: Y.Hisaki <yhisaki31@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
) * update readme Signed-off-by: Y.Hisaki <yhisaki31@gmail.com> * refactoring Signed-off-by: Y.Hisaki <yhisaki31@gmail.com> * remove string reporter Signed-off-by: Y.Hisaki <yhisaki31@gmail.com> * fix readme.md Signed-off-by: Y.Hisaki <yhisaki31@gmail.com> * change node name of example Signed-off-by: Y.Hisaki <yhisaki31@gmail.com> * update readme Signed-off-by: Y.Hisaki <yhisaki31@gmail.com> --------- Signed-off-by: Y.Hisaki <yhisaki31@gmail.com>
) * update readme Signed-off-by: Y.Hisaki <yhisaki31@gmail.com> * refactoring Signed-off-by: Y.Hisaki <yhisaki31@gmail.com> * remove string reporter Signed-off-by: Y.Hisaki <yhisaki31@gmail.com> * fix readme.md Signed-off-by: Y.Hisaki <yhisaki31@gmail.com> * change node name of example Signed-off-by: Y.Hisaki <yhisaki31@gmail.com> * update readme Signed-off-by: Y.Hisaki <yhisaki31@gmail.com> --------- Signed-off-by: Y.Hisaki <yhisaki31@gmail.com>
Description
add_report()
in the comments.Related links
How was this PR tested?
Notes for reviewers
None.
Interface changes
None.
Effects on system behavior
None.