Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(euclidean_cluster)!: fix namespace and directory structure #7887

Merged
merged 2 commits into from
Jul 9, 2024
Merged

refactor(euclidean_cluster)!: fix namespace and directory structure #7887

merged 2 commits into from
Jul 9, 2024

Conversation

technolojin
Copy link
Contributor

@technolojin technolojin commented Jul 8, 2024 •
edited
Loading

Description

This PR puts headers in the autoware namespace.

Additional works

  1. Align directory structure to follow the coding guidelines.

Related links

Part of: autowarefoundation/autoware#4569

How was this PR tested?

Tested in a local recompute environment and the TIER IV Cloud environment.

Notes for reviewers

None.

Interface changes

None.

Effects on system behavior

None.

@technolojin
refactor: update include paths for euclidean_cluster code
c4c1c81 
Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp>

refactor: fix namespace

Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp>

chore: update include paths for euclidean_cluster code

Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp>
@github-actions github-actions bot added the component:perception Advanced sensor data processing and environment understanding. (auto-assigned) label Jul 8, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 8, 2024 •
edited
Loading

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

@technolojin technolojin marked this pull request as ready for review July 8, 2024 05:28
@technolojin technolojin added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Jul 8, 2024
@codecov Codecov
Copy link

codecov bot commented Jul 8, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.

Project coverage is 28.42%. Comparing base (e1cd1da) to head (03e6d35).
Report is 3 commits behind head on main.

Files Patch % Lines
...ction_by_tracker/src/detection_by_tracker_node.cpp 0.00% 1 Missing ⚠️
...n/euclidean_cluster/src/euclidean_cluster_node.cpp 0.00% 1 Missing ⚠️
...er/src/voxel_grid_based_euclidean_cluster_node.cpp 0.00% 1 Missing ⚠️
...on_based_fusion/src/roi_pointcloud_fusion/node.cpp 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #7887      +/-   ##
==========================================
- Coverage   28.43%   28.42%   -0.01%     
==========================================
  Files        1589     1591       +2     
  Lines      116187   116215      +28     
  Branches    49548    49552       +4     
==========================================
  Hits        33034    33034              
- Misses      74159    74187      +28     
  Partials     8994     8994
Flag Coverage Δ *Carryforward flag
differential 2.68% <0.00%> (?)
total 28.43% <ø> (+<0.01%) ⬆️ Carriedforward from e1cd1da

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@technolojin
Copy link
Contributor Author

@badai-nguyen @YoshiRi
Can you review this PR please? This PR requires both of your approval.

YoshiRi
YoshiRi approved these changes Jul 9, 2024
View reviewed changes
Copy link
Contributor

@YoshiRi YoshiRi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@technolojin technolojin enabled auto-merge (squash) July 9, 2024 02:23
@technolojin technolojin disabled auto-merge July 9, 2024 02:23
badai-nguyen
badai-nguyen approved these changes Jul 9, 2024
View reviewed changes
Copy link
Contributor

@badai-nguyen badai-nguyen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@technolojin technolojin merged commit 6d0247e into autowarefoundation:main Jul 9, 2024
38 of 39 checks passed
kyoichi-sugahara pushed a commit to kyoichi-sugahara/autoware.universe that referenced this pull request Jul 9, 2024
@technolojin @pre-commit-ci @kyoichi-sugahara
refactor(euclidean_cluster)!: fix namespace and directory structure (a…
9a1691d 
…utowarefoundation#7887)

* refactor: update include paths for euclidean_cluster code

Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp>

refactor: fix namespace

Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp>

chore: update include paths for euclidean_cluster code

Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp>

* style(pre-commit): autofix

---------

Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
@technolojin technolojin deleted the refactor/namespace-euclidean_cluster branch July 9, 2024 04:05
palas21 pushed a commit to palas21/autoware.universe that referenced this pull request Jul 12, 2024
@technolojin @pre-commit-ci @palas21
refactor(euclidean_cluster)!: fix namespace and directory structure (a…
8a7e46e 
…utowarefoundation#7887)

* refactor: update include paths for euclidean_cluster code

Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp>

refactor: fix namespace

Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp>

chore: update include paths for euclidean_cluster code

Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp>

* style(pre-commit): autofix

---------

Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Signed-off-by: palas21 <palas21@itu.edu.tr>
KhalilSelyan pushed a commit that referenced this pull request Jul 22, 2024
@technolojin @pre-commit-ci
refactor(euclidean_cluster)!: fix namespace and directory structure (#…
ebb1aaf 
…7887)

* refactor: update include paths for euclidean_cluster code

Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp>

refactor: fix namespace

Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp>

chore: update include paths for euclidean_cluster code

Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp>

* style(pre-commit): autofix

---------

Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Ariiees pushed a commit to Ariiees/autoware.universe that referenced this pull request Jul 22, 2024
@technolojin @pre-commit-ci @Ariiees
refactor(euclidean_cluster)!: fix namespace and directory structure (a…
022e8d2 
…utowarefoundation#7887)

* refactor: update include paths for euclidean_cluster code

Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp>

refactor: fix namespace

Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp>

chore: update include paths for euclidean_cluster code

Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp>

* style(pre-commit): autofix

---------

Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@YoshiRi YoshiRi YoshiRi approved these changes

@badai-nguyen badai-nguyen badai-nguyen approved these changes

@kminoda kminoda Awaiting requested review from kminoda

@ktro2828 ktro2828 Awaiting requested review from ktro2828

@miursh miursh Awaiting requested review from miursh

@tzhong518 tzhong518 Awaiting requested review from tzhong518

@yukkysaito yukkysaito Awaiting requested review from yukkysaito

Assignees

@YoshiRi YoshiRi

@badai-nguyen badai-nguyen

Labels
component:perception Advanced sensor data processing and environment understanding. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@technolojin @YoshiRi @badai-nguyen