Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(autoware_universe_utils): fix constVariableReference #7883

Conversation

kobayu858
Copy link
Contributor

Description

This is a fix based on cppcheck constVariableReference warnings

common/object_recognition_utils/src/conversion.cpp:49:15: style: Variable 'tracked_object' can be declared as reference to const [constVariableReference]
  for (auto & tracked_object : tracked_objects.objects) {
              ^

common/object_recognition_utils/src/conversion.cpp:77:15: style: Variable 'detected_object' can be declared as reference to const [constVariableReference]
  for (auto & detected_object : detected_objects.objects) {
              ^

Related links

Parent Issue:

  • Link

How was this PR tested?

Notes for reviewers

None.

Interface changes

None.

Effects on system behavior

None.

kobayu858 and others added 2 commits July 8, 2024 09:05
Signed-off-by: kobayu858 <yutaro.kobayashi@tier4.jp>
@github-actions github-actions bot added the component:common Common packages from the autoware-common repository. (auto-assigned) label Jul 8, 2024
Copy link

github-actions bot commented Jul 8, 2024

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

@kobayu858 kobayu858 marked this pull request as draft July 8, 2024 02:32
@atsushi421 atsushi421 requested a review from veqcc July 8, 2024 02:54
@kobayu858 kobayu858 marked this pull request as ready for review July 8, 2024 04:04
@kobayu858 kobayu858 added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Jul 8, 2024
Copy link

codecov bot commented Jul 8, 2024

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 27.71%. Comparing base (106625a) to head (72b5272).
Report is 5 commits behind head on main.

Files Patch % Lines
common/object_recognition_utils/src/conversion.cpp 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7883      +/-   ##
==========================================
- Coverage   28.95%   27.71%   -1.24%     
==========================================
  Files        1606     1658      +52     
  Lines      117598   119834    +2236     
  Branches    50597    50162     -435     
==========================================
- Hits        34046    33210     -836     
- Misses      74299    77609    +3310     
+ Partials     9253     9015     -238     
Flag Coverage Δ *Carryforward flag
differential 18.30% <0.00%> (?)
total 28.40% <ø> (-0.55%) ⬇️ Carriedforward from 3063a7c

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kobayu858
Copy link
Contributor Author

@scepter914 @miursh @takayuki5168 @YoshiRi

Please confirm the PR. Thank you very much.

Copy link
Contributor

@takayuki5168 takayuki5168 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@kobayu858 kobayu858 merged commit 3c49692 into autowarefoundation:main Jul 17, 2024
30 checks passed
yhisaki pushed a commit to yhisaki/autoware.universe that referenced this pull request Jul 19, 2024
…ndation#7883)

fix:constVariableReference

Signed-off-by: kobayu858 <yutaro.kobayashi@tier4.jp>
Signed-off-by: Y.Hisaki <yhisaki31@gmail.com>
Ariiees pushed a commit to Ariiees/autoware.universe that referenced this pull request Jul 22, 2024
…ndation#7883)

fix:constVariableReference

Signed-off-by: kobayu858 <yutaro.kobayashi@tier4.jp>
@kobayu858 kobayu858 deleted the fix/cppcheck_constVariableReference_com-1 branch July 23, 2024 01:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:common Common packages from the autoware-common repository. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants