-
Notifications
You must be signed in to change notification settings - Fork 693
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(autoware_test_utils): add qos handler in pub/sub #7856
feat(autoware_test_utils): add qos handler in pub/sub #7856
Conversation
Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com>
Thank you for contributing to the Autoware project! 🚧 If your pull request is in progress, switch it to draft mode. Please ensure:
|
Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #7856 +/- ##
==========================================
- Coverage 23.89% 23.86% -0.03%
==========================================
Files 1381 1384 +3
Lines 101831 101865 +34
Branches 38780 38782 +2
==========================================
- Hits 24333 24314 -19
- Misses 75035 75086 +51
- Partials 2463 2465 +2
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Thanks!
…tion#7856) * feat: add qos handler in pub/sub Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com> * style(pre-commit): autofix * feat: update test_pub_msg function to not use setpublisher function Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com> --------- Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Signed-off-by: xtk8532704 <1041084556@qq.com>
Description
Enable to give pub/sub qos settings by external argument.
Disable automatic qos overwrite in
setPublisher
function.Related links
Parent Issue:
How was this PR tested?
Notes for reviewers
None.
Interface changes
None.
Effects on system behavior
None.