refactor(shape_estimation)!: fix namespace and directory structure #7844

technolojin · 2024-07-04T09:00:26Z

Description

This PR puts headers in the autoware namespace.

Additional works

Align directory structure to follow the coding guidelines.

How was this PR tested?

Tested in a local recompute environment and the TIER IV Cloud environment.

Notes for reviewers

None.

Interface changes

None.

Effects on system behavior

None.

refactor: relocate headers refactor: add namespace refactor: update shape_estimation namespace on the user side Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp>

refactor: update namespace of the node refactor: update namespace and directory structure for detection_by_tracker node Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp>

…racker node Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp>

github-actions · 2024-07-04T09:00:43Z

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

You've checked our contribution guidelines.
Your PR follows our pull request guidelines.
All required CI checks pass before marking the PR ready for review.

codecov · 2024-07-05T04:44:06Z

Codecov Report

Attention: Patch coverage is 9.67742% with 56 lines in your changes missing coverage. Please review.

Project coverage is 28.64%. Comparing base (99c7c57) to head (23d7434).
Report is 32 commits behind head on main.

Files	Patch %	Lines
...tection_by_tracker/src/tracker/tracker_handler.cpp	0.00%	31 Missing ⚠️
...erception/shape_estimation/lib/shape_estimator.cpp	20.00%	12 Missing ⚠️
...erception/detection_by_tracker/src/utils/utils.hpp	0.00%	5 Missing ⚠️
...ction_by_tracker/src/detection_by_tracker_node.cpp	0.00%	3 Missing ⚠️
...tection_by_tracker/src/tracker/tracker_handler.hpp	0.00%	2 Missing ⚠️
...toware/shape_estimation/corrector/no_corrector.hpp	0.00%	1 Missing ⚠️
...ude/autoware/shape_estimation/filter/no_filter.hpp	0.00%	1 Missing ⚠️
...ion/shape_estimation/src/shape_estimation_node.cpp	0.00%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #7844      +/-   ##
==========================================
- Coverage   28.65%   28.64%   -0.02%     
==========================================
  Files        1587     1608      +21     
  Lines      116361   116474     +113     
  Branches    49700    49718      +18     
==========================================
+ Hits        33345    33359      +14     
- Misses      74014    74110      +96     
- Partials     9002     9005       +3

Flag	Coverage Δ		*Carryforward flag
differential	`2.99% <9.67%> (?)`
total	`28.66% <ø> (+<0.01%)`	⬆️	Carriedforward from 471c870

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

yukkysaito

LGTM

yukkysaito · 2024-07-05T07:34:18Z

perception/shape_estimation/include/autoware/shape_estimation/shape_estimator.hpp

It seems that shape_estimator.hpp needs to be made public for other packages, but many of the other .hpp files don't seem to need to be public. As a first step, it might be a good idea to merge everything first and then move the .hpp files that don't need to be public afterwards.

I know that other than shape_estimator.hpp is closed within the package.
Directory structure may need to be aligned and fixed later.

YoshiRi

LGTM with a trivial comment

perception/detection_by_tracker/src/tracker/tracker_handler.hpp

Co-authored-by: Yoshi Ri <yoshiyoshidetteiu@gmail.com> Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp>

…utowarefoundation#7844) * chore: Update shape_estimation library and node names refactor: relocate headers refactor: add namespace refactor: update shape_estimation namespace on the user side Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp> * refactor: update namespace of the node refactor: update namespace of the node refactor: update namespace and directory structure for detection_by_tracker node Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp> * refactor: update namespace and directory structure for detection_by_tracker node Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp> * Update perception/detection_by_tracker/src/tracker/tracker_handler.hpp Co-authored-by: Yoshi Ri <yoshiyoshidetteiu@gmail.com> Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp> --------- Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp> Co-authored-by: Yoshi Ri <yoshiyoshidetteiu@gmail.com> Signed-off-by: palas21 <palas21@itu.edu.tr>

…utowarefoundation#7844) * chore: Update shape_estimation library and node names refactor: relocate headers refactor: add namespace refactor: update shape_estimation namespace on the user side Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp> * refactor: update namespace of the node refactor: update namespace of the node refactor: update namespace and directory structure for detection_by_tracker node Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp> * refactor: update namespace and directory structure for detection_by_tracker node Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp> * Update perception/detection_by_tracker/src/tracker/tracker_handler.hpp Co-authored-by: Yoshi Ri <yoshiyoshidetteiu@gmail.com> Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp> --------- Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp> Co-authored-by: Yoshi Ri <yoshiyoshidetteiu@gmail.com>

…7844) * chore: Update shape_estimation library and node names refactor: relocate headers refactor: add namespace refactor: update shape_estimation namespace on the user side Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp> * refactor: update namespace of the node refactor: update namespace of the node refactor: update namespace and directory structure for detection_by_tracker node Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp> * refactor: update namespace and directory structure for detection_by_tracker node Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp> * Update perception/detection_by_tracker/src/tracker/tracker_handler.hpp Co-authored-by: Yoshi Ri <yoshiyoshidetteiu@gmail.com> Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp> --------- Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp> Co-authored-by: Yoshi Ri <yoshiyoshidetteiu@gmail.com>

…utowarefoundation#7844) * chore: Update shape_estimation library and node names refactor: relocate headers refactor: add namespace refactor: update shape_estimation namespace on the user side Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp> * refactor: update namespace of the node refactor: update namespace of the node refactor: update namespace and directory structure for detection_by_tracker node Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp> * refactor: update namespace and directory structure for detection_by_tracker node Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp> * Update perception/detection_by_tracker/src/tracker/tracker_handler.hpp Co-authored-by: Yoshi Ri <yoshiyoshidetteiu@gmail.com> Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp> --------- Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp> Co-authored-by: Yoshi Ri <yoshiyoshidetteiu@gmail.com>

technolojin added 3 commits July 4, 2024 17:59

chore: Update shape_estimation library and node names

e31f7b3

refactor: relocate headers refactor: add namespace refactor: update shape_estimation namespace on the user side Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp>

refactor: update namespace of the node

30e2e6a

refactor: update namespace of the node refactor: update namespace and directory structure for detection_by_tracker node Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp>

refactor: update namespace and directory structure for detection_by_t…

471c870

…racker node Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp>

github-actions bot added type:documentation Creating or refining documentation. (auto-assigned) component:perception Advanced sensor data processing and environment understanding. (auto-assigned) labels Jul 4, 2024

technolojin marked this pull request as ready for review July 5, 2024 04:33

technolojin requested review from YoshiRi and yukkysaito as code owners July 5, 2024 04:33

technolojin added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Jul 5, 2024

yukkysaito approved these changes Jul 5, 2024

View reviewed changes

yukkysaito self-requested a review July 5, 2024 07:30

yukkysaito reviewed Jul 5, 2024

View reviewed changes

YoshiRi approved these changes Jul 5, 2024

View reviewed changes

perception/detection_by_tracker/src/tracker/tracker_handler.hpp Outdated Show resolved Hide resolved

Update perception/detection_by_tracker/src/tracker/tracker_handler.hpp

23d7434

Co-authored-by: Yoshi Ri <yoshiyoshidetteiu@gmail.com> Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp>

technolojin force-pushed the refactor/namespace-shape_estimation branch from 6fefe5d to 23d7434 Compare July 5, 2024 09:18

technolojin enabled auto-merge (squash) July 5, 2024 09:18

technolojin merged commit 26e87ea into autowarefoundation:main Jul 5, 2024
29 of 30 checks passed

technolojin deleted the refactor/namespace-shape_estimation branch July 8, 2024 05:19

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

refactor(shape_estimation)!: fix namespace and directory structure #7844

refactor(shape_estimation)!: fix namespace and directory structure #7844

technolojin commented Jul 4, 2024 •

edited

Loading

github-actions bot commented Jul 4, 2024 •

edited

Loading

codecov bot commented Jul 5, 2024 •

edited

Loading

yukkysaito left a comment

yukkysaito Jul 5, 2024

technolojin Jul 5, 2024

YoshiRi left a comment

refactor(shape_estimation)!: fix namespace and directory structure #7844

refactor(shape_estimation)!: fix namespace and directory structure #7844

Conversation

technolojin commented Jul 4, 2024 • edited Loading

Description

Related links

How was this PR tested?

Notes for reviewers

Interface changes

Effects on system behavior

github-actions bot commented Jul 4, 2024 • edited Loading

codecov bot commented Jul 5, 2024 • edited Loading

Codecov Report

yukkysaito left a comment

Choose a reason for hiding this comment

yukkysaito Jul 5, 2024

Choose a reason for hiding this comment

technolojin Jul 5, 2024

Choose a reason for hiding this comment

YoshiRi left a comment

Choose a reason for hiding this comment

technolojin commented Jul 4, 2024 •

edited

Loading

github-actions bot commented Jul 4, 2024 •

edited

Loading

codecov bot commented Jul 5, 2024 •

edited

Loading