Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(freespace_planning_algorithms): add is_back flag into the return of A* python wrapper #7831

Merged

Conversation

TakumIto
Copy link
Contributor

@TakumIto TakumIto commented Jul 4, 2024

Description

This is an updated version of the A* python wrapper

The previous version does not have is_back in the result return of A* search. I append it with this PR.

Related links

#6398
Evaluator: https://evaluation.tier4.jp/evaluation/reports/54647b99-62d4-5849-b6f8-d7d78de25c8c?project_id=prd_jt

Interface changes

ROS Topic Changes

N/A

ROS Parameter Changes

N/A

Effects on system behavior

This feature is independent of the main autoware features. There are no effects.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: Takumi Ito <takumi.ito@tier4.jp>
@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label Jul 4, 2024
Copy link

github-actions bot commented Jul 4, 2024

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

@kosuke55 kosuke55 added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Jul 4, 2024
@kosuke55 kosuke55 enabled auto-merge (squash) July 4, 2024 05:11
Copy link

codecov bot commented Jul 4, 2024

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 28.66%. Comparing base (909004e) to head (f618b13).
Report is 11 commits behind head on main.

Files Patch % Lines
...ng_algorithms/scripts/bind/astar_search_pybind.cpp 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7831      +/-   ##
==========================================
- Coverage   28.68%   28.66%   -0.02%     
==========================================
  Files        1587     1593       +6     
  Lines      116304   116349      +45     
  Branches    49652    49653       +1     
==========================================
  Hits        33356    33356              
- Misses      73892    73937      +45     
  Partials     9056     9056              
Flag Coverage Δ *Carryforward flag
differential 15.40% <0.00%> (?)
total 28.68% <ø> (+<0.01%) ⬆️ Carriedforward from 909004e

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kosuke55 kosuke55 merged commit dabf104 into autowarefoundation:main Jul 4, 2024
45 checks passed
@kosuke55 kosuke55 deleted the chore/astar_python_add_is_back branch July 4, 2024 05:33
palas21 pushed a commit to palas21/autoware.universe that referenced this pull request Jul 12, 2024
… of A* python wrapper (autowarefoundation#7831)

add is_back flag to the return of getWaypoints

Signed-off-by: Takumi Ito <takumi.ito@tier4.jp>
Co-authored-by: Takumi Ito <takumi.ito@tier4.jp>
Signed-off-by: palas21 <palas21@itu.edu.tr>
tby-udel pushed a commit to tby-udel/autoware.universe that referenced this pull request Jul 14, 2024
… of A* python wrapper (autowarefoundation#7831)

add is_back flag to the return of getWaypoints

Signed-off-by: Takumi Ito <takumi.ito@tier4.jp>
Co-authored-by: Takumi Ito <takumi.ito@tier4.jp>
KhalilSelyan pushed a commit that referenced this pull request Jul 22, 2024
… of A* python wrapper (#7831)

add is_back flag to the return of getWaypoints

Signed-off-by: Takumi Ito <takumi.ito@tier4.jp>
Co-authored-by: Takumi Ito <takumi.ito@tier4.jp>
Ariiees pushed a commit to Ariiees/autoware.universe that referenced this pull request Jul 22, 2024
… of A* python wrapper (autowarefoundation#7831)

add is_back flag to the return of getWaypoints

Signed-off-by: Takumi Ito <takumi.ito@tier4.jp>
Co-authored-by: Takumi Ito <takumi.ito@tier4.jp>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants