Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(system error monitor): use polling subscriber #7736

Conversation

masahiro-kubota
Copy link

Description

The same as #6997 based on the discussion, the polling subscriber is used in the system error monitor.

Tests performed

psim test were performed
Since there was no ROSbag file for the new topic type, I changed the topic type in the code and verified that the topic was output using the ROSbag file of the old topic type.

Effects on system behavior

Nothing but more efficient CPU usage

Interface changes

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Sorry, something went wrong.

… with take

Signed-off-by: Masahiro Kubota <norikenpi@gmail.com>
Signed-off-by: Masahiro Kubota <norikenpi@gmail.com>
Signed-off-by: Masahiro Kubota <norikenpi@gmail.com>
Signed-off-by: Masahiro Kubota <norikenpi@gmail.com>
Signed-off-by: Masahiro Kubota <norikenpi@gmail.com>
Signed-off-by: Masahiro Kubota <norikenpi@gmail.com>
@masahiro-kubota masahiro-kubota added run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) tag:run-clang-tidy-differential labels Jun 27, 2024
@github-actions github-actions bot added the component:system System design and integration. (auto-assigned) label Jun 27, 2024
Copy link

github-actions bot commented Jun 27, 2024

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

masahiro-kubota and others added 15 commits June 28, 2024 04:48
Signed-off-by: Masahiro Kubota <norikenpi@gmail.com>
Signed-off-by: Masahiro Kubota <norikenpi@gmail.com>
Signed-off-by: Masahiro Kubota <norikenpi@gmail.com>
Signed-off-by: Masahiro Kubota <norikenpi@gmail.com>
Signed-off-by: Masahiro Kubota <norikenpi@gmail.com>
…ub.com:masahiro-kubota/autoware.universe into feat/system_error_monitor/subscribe_by_polling
Signed-off-by: Masahiro Kubota <norikenpi@gmail.com>
Signed-off-by: Masahiro Kubota <norikenpi@gmail.com>
Signed-off-by: Masahiro Kubota <norikenpi@gmail.com>
Copy link

codecov bot commented Jun 27, 2024

Codecov Report

Attention: Patch coverage is 0% with 21 lines in your changes missing coverage. Please review.

Project coverage is 0.00%. Comparing base (3d849e9) to head (99cae11).
Report is 1257 commits behind head on main.

Files Patch % Lines
...em_error_monitor/src/system_error_monitor_core.cpp 0.00% 21 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #7736       +/-   ##
==========================================
- Coverage   15.09%   0.00%   -15.10%     
==========================================
  Files        1967      34     -1933     
  Lines      135941    2075   -133866     
  Branches    42122     136    -41986     
==========================================
- Hits        20520       0    -20520     
+ Misses      92700    2075    -90625     
+ Partials    22721       0    -22721     
Flag Coverage Δ
differential 0.00% <0.00%> (?)
total ?

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

masahiro-kubota and others added 3 commits June 28, 2024 05:46
Signed-off-by: Masahiro Kubota <norikenpi@gmail.com>
Signed-off-by: norikenpi <norikenpi@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:system System design and integration. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants