-
Notifications
You must be signed in to change notification settings - Fork 703
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(system error monitor): use polling subscriber #7736
feat(system error monitor): use polling subscriber #7736
Conversation
… with take Signed-off-by: Masahiro Kubota <norikenpi@gmail.com>
Signed-off-by: Masahiro Kubota <norikenpi@gmail.com>
Signed-off-by: Masahiro Kubota <norikenpi@gmail.com>
Signed-off-by: Masahiro Kubota <norikenpi@gmail.com>
Signed-off-by: Masahiro Kubota <norikenpi@gmail.com>
Signed-off-by: Masahiro Kubota <norikenpi@gmail.com>
Thank you for contributing to the Autoware project! 🚧 If your pull request is in progress, switch it to draft mode. Please ensure:
|
Signed-off-by: Masahiro Kubota <norikenpi@gmail.com>
Signed-off-by: Masahiro Kubota <norikenpi@gmail.com>
Signed-off-by: Masahiro Kubota <norikenpi@gmail.com>
Signed-off-by: Masahiro Kubota <norikenpi@gmail.com>
Signed-off-by: Masahiro Kubota <norikenpi@gmail.com>
…ub.com:masahiro-kubota/autoware.universe into feat/system_error_monitor/subscribe_by_polling
Signed-off-by: Masahiro Kubota <norikenpi@gmail.com>
Signed-off-by: Masahiro Kubota <norikenpi@gmail.com>
Signed-off-by: Masahiro Kubota <norikenpi@gmail.com>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #7736 +/- ##
==========================================
- Coverage 15.09% 0.00% -15.10%
==========================================
Files 1967 34 -1933
Lines 135941 2075 -133866
Branches 42122 136 -41986
==========================================
- Hits 20520 0 -20520
+ Misses 92700 2075 -90625
+ Partials 22721 0 -22721
☔ View full report in Codecov by Sentry. |
Signed-off-by: Masahiro Kubota <norikenpi@gmail.com>
Signed-off-by: norikenpi <norikenpi@gmail.com>
Description
The same as #6997 based on the discussion, the polling subscriber is used in the system error monitor.
Tests performed
psim test were performed
Since there was no ROSbag file for the new topic type, I changed the topic type in the code and verified that the topic was output using the ROSbag file of the old topic type.
Effects on system behavior
Nothing but more efficient CPU usage
Interface changes
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.