Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(mapless_architecture): add mapless_architecture #7709

6: Check TODOs/FIXMEs

ff9dfd8
Select commit
Loading
Failed to load commit list.
Closed

feat(mapless_architecture): add mapless_architecture #7709

6: Check TODOs/FIXMEs
ff9dfd8
Select commit
Loading
Failed to load commit list.
CodeScene Delta Analysis / CodeScene Cloud Delta Analysis (main) failed Jul 10, 2024 in 57s

CodeScene PR Check

Code Health Quality Gates: FAILED

Code Health of new files: 8.52

  • Declining Code Health: 24 findings(s) 🚩

View detailed results in CodeScene

Details

🚩 Declining Code Health (highest to lowest):

  • Complex Method mission_planner_node.cpp: MissionPlannerNode::CallbackLocalMapMessages_
  • Overall Code Complexity mission_planner_node.cpp
  • Deep, Nested Complexity mission_planner_node.cpp: MissionPlannerNode::IsOnGoalLane_
  • Code Duplication test_mission_planner_core.cpp
  • Deep, Nested Complexity mission_lane_converter_node.cpp: MissionLaneConverterNode::TransformToGlobalFrame
  • Large Method mission_lane_converter_node.cpp: MissionLaneConverterNode::ConvertMissionToTrajectory
  • Complex Method helper_functions.cpp: GetNeighboringLaneletID
  • Deep, Nested Complexity helper_functions.cpp: GetRelevantAdjacentLanelets
  • Deep, Nested Complexity helper_functions.cpp: GetAllNeighborsOfLane
  • Primitive Obsession helper_functions.cpp
  • Excess Number of Function Arguments helper_functions.cpp: GetNeighboringLaneletID
  • Complex Method mission_lane_converter_node.cpp: MissionLaneConverterNode::TransformToGlobalFrame
  • Excess Number of Function Arguments mission_lane_converter_node.cpp: MissionLaneConverterNode::CreateMotionPlannerInput_
  • Complex Method mission_planner_node.cpp: MissionPlannerNode::ConvertInput2LaneletFormat
  • Bumpy Road Ahead mission_planner_node.cpp: MissionPlannerNode::CallbackLocalMapMessages_
  • Bumpy Road Ahead helper_functions.cpp: GetCompletedLaneletSequence
  • Bumpy Road Ahead helper_functions.cpp: GetNeighboringLaneletID
  • Bumpy Road Ahead helper_functions.cpp: CreateMarkerArray
  • Bumpy Road Ahead mission_lane_converter_node.cpp: MissionLaneConverterNode::TransformToGlobalFrame
  • Bumpy Road Ahead mission_planner_node.cpp: MissionPlannerNode::CallbackOdometryMessages_
  • Bumpy Road Ahead mission_planner_node.cpp: MissionPlannerNode::IsOnGoalLane_
  • Bumpy Road Ahead mission_planner_node.cpp: MissionPlannerNode::ConvertInput2LaneletFormat
  • Bumpy Road Ahead helper_functions.cpp: GetAllNeighboringLaneletIDs
  • Bumpy Road Ahead helper_functions.cpp: CalculatePredecessors

Annotations

Check warning on line 270 in planning/mapless_architecture/autoware_local_mission_planner/src/mission_planner_node.cpp

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)

❌ New issue: Complex Method

MissionPlannerNode::CallbackLocalMapMessages_ has a cyclomatic complexity of 23, threshold = 9. This function has many conditional statements (e.g. if, for, while), leading to lower code health. Avoid adding more conditionals and code to it without refactoring.

Check warning on line 693 in planning/mapless_architecture/autoware_local_mission_planner/src/mission_planner_node.cpp

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)

❌ New issue: Complex Method

MissionPlannerNode::ConvertInput2LaneletFormat has a cyclomatic complexity of 10, threshold = 9. This function has many conditional statements (e.g. if, for, while), leading to lower code health. Avoid adding more conditionals and code to it without refactoring.

Check warning on line 270 in planning/mapless_architecture/autoware_local_mission_planner/src/mission_planner_node.cpp

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)

❌ New issue: Bumpy Road Ahead

MissionPlannerNode::CallbackLocalMapMessages_ has 4 blocks with nested conditional logic. Any nesting of 2 or deeper is considered. Threshold is one single, nested block per function. The Bumpy Road code smell is a function that contains multiple chunks of nested conditional logic. The deeper the nesting and the more bumps, the lower the code health.

Check warning on line 380 in planning/mapless_architecture/autoware_local_mission_planner/src/mission_planner_node.cpp

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)

❌ New issue: Bumpy Road Ahead

MissionPlannerNode::CallbackOdometryMessages_ has 2 blocks with nested conditional logic. Any nesting of 2 or deeper is considered. Threshold is one single, nested block per function. The Bumpy Road code smell is a function that contains multiple chunks of nested conditional logic. The deeper the nesting and the more bumps, the lower the code health.

Check warning on line 558 in planning/mapless_architecture/autoware_local_mission_planner/src/mission_planner_node.cpp

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)

❌ New issue: Bumpy Road Ahead

MissionPlannerNode::IsOnGoalLane_ has 2 blocks with nested conditional logic. Any nesting of 2 or deeper is considered. Threshold is one single, nested block per function. The Bumpy Road code smell is a function that contains multiple chunks of nested conditional logic. The deeper the nesting and the more bumps, the lower the code health.

Check warning on line 693 in planning/mapless_architecture/autoware_local_mission_planner/src/mission_planner_node.cpp

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)

❌ New issue: Bumpy Road Ahead

MissionPlannerNode::ConvertInput2LaneletFormat has 2 blocks with nested conditional logic. Any nesting of 2 or deeper is considered. Threshold is one single, nested block per function. The Bumpy Road code smell is a function that contains multiple chunks of nested conditional logic. The deeper the nesting and the more bumps, the lower the code health.

Check warning on line 1 in planning/mapless_architecture/autoware_local_mission_planner/src/mission_planner_node.cpp

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)

❌ New issue: Overall Code Complexity

This module has a mean cyclomatic complexity of 5.00 across 15 functions. The mean complexity threshold is 4. This file has many conditional statements (e.g. if, for, while) across its implementation, leading to lower code health. Avoid adding more conditionals.

Check warning on line 558 in planning/mapless_architecture/autoware_local_mission_planner/src/mission_planner_node.cpp

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)

❌ New issue: Deep, Nested Complexity

MissionPlannerNode::IsOnGoalLane_ has a nested complexity depth of 4, threshold = 4. This function contains deeply nested logic such as if statements and/or loops. The deeper the nesting, the lower the code health.

Check warning on line 280 in planning/mapless_architecture/autoware_local_mission_planner/test/src/test_mission_planner_core.cpp

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)

❌ New issue: Code Duplication

The module contains 2 functions with similar structure: CreateLane,GetTestRoadModelForRecenterTests. Avoid duplicated, aka copy-pasted, code inside the module. More duplication lowers the code health.

Check warning on line 603 in planning/mapless_architecture/autoware_mission_lane_converter/src/mission_lane_converter_node.cpp

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)

❌ New issue: Complex Method

MissionLaneConverterNode::TransformToGlobalFrame has a cyclomatic complexity of 10, threshold = 9. This function has many conditional statements (e.g. if, for, while), leading to lower code health. Avoid adding more conditionals and code to it without refactoring.

Check warning on line 315 in planning/mapless_architecture/autoware_mission_lane_converter/src/mission_lane_converter_node.cpp

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)

❌ New issue: Large Method

MissionLaneConverterNode::ConvertMissionToTrajectory has 103 lines, threshold = 70. Large functions with many lines of code are generally harder to understand and lower the code health. Avoid adding more lines to this function.

Check warning on line 603 in planning/mapless_architecture/autoware_mission_lane_converter/src/mission_lane_converter_node.cpp

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)

❌ New issue: Bumpy Road Ahead

MissionLaneConverterNode::TransformToGlobalFrame has 3 blocks with nested conditional logic. Any nesting of 2 or deeper is considered. Threshold is one single, nested block per function. The Bumpy Road code smell is a function that contains multiple chunks of nested conditional logic. The deeper the nesting and the more bumps, the lower the code health.

Check warning on line 603 in planning/mapless_architecture/autoware_mission_lane_converter/src/mission_lane_converter_node.cpp

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)

❌ New issue: Deep, Nested Complexity

MissionLaneConverterNode::TransformToGlobalFrame has a nested complexity depth of 4, threshold = 4. This function contains deeply nested logic such as if statements and/or loops. The deeper the nesting, the lower the code health.

Check warning on line 368 in planning/mapless_architecture/autoware_mission_lane_converter/src/mission_lane_converter_node.cpp

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)

❌ New issue: Excess Number of Function Arguments

MissionLaneConverterNode::CreateMotionPlannerInput_ has 5 arguments, threshold = 4. This function has too many arguments, indicating a lack of encapsulation. Avoid adding more arguments.

Check warning on line 379 in planning/mapless_architecture/autoware_local_mission_planner_common/src/helper_functions.cpp

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)

❌ New issue: Complex Method

GetNeighboringLaneletID has a cyclomatic complexity of 9, threshold = 9. This function has many conditional statements (e.g. if, for, while), leading to lower code health. Avoid adding more conditionals and code to it without refactoring.

Check warning on line 291 in planning/mapless_architecture/autoware_local_mission_planner_common/src/helper_functions.cpp

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)

❌ New issue: Bumpy Road Ahead

GetCompletedLaneletSequence has 3 blocks with nested conditional logic. Any nesting of 2 or deeper is considered. Threshold is one single, nested block per function. The Bumpy Road code smell is a function that contains multiple chunks of nested conditional logic. The deeper the nesting and the more bumps, the lower the code health.

Check warning on line 379 in planning/mapless_architecture/autoware_local_mission_planner_common/src/helper_functions.cpp

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)

❌ New issue: Bumpy Road Ahead

GetNeighboringLaneletID has 3 blocks with nested conditional logic. Any nesting of 2 or deeper is considered. Threshold is one single, nested block per function. The Bumpy Road code smell is a function that contains multiple chunks of nested conditional logic. The deeper the nesting and the more bumps, the lower the code health.

Check warning on line 518 in planning/mapless_architecture/autoware_local_mission_planner_common/src/helper_functions.cpp

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)

❌ New issue: Bumpy Road Ahead

CreateMarkerArray has 3 blocks with nested conditional logic. Any nesting of 2 or deeper is considered. Threshold is one single, nested block per function. The Bumpy Road code smell is a function that contains multiple chunks of nested conditional logic. The deeper the nesting and the more bumps, the lower the code health.

Check warning on line 326 in planning/mapless_architecture/autoware_local_mission_planner_common/src/helper_functions.cpp

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)

❌ New issue: Bumpy Road Ahead

GetAllNeighboringLaneletIDs has 2 blocks with nested conditional logic. Any nesting of 2 or deeper is considered. Threshold is one single, nested block per function. The Bumpy Road code smell is a function that contains multiple chunks of nested conditional logic. The deeper the nesting and the more bumps, the lower the code health.

Check warning on line 663 in planning/mapless_architecture/autoware_local_mission_planner_common/src/helper_functions.cpp

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)

❌ New issue: Bumpy Road Ahead

CalculatePredecessors has 2 blocks with nested conditional logic. Any nesting of 2 or deeper is considered. Threshold is one single, nested block per function. The Bumpy Road code smell is a function that contains multiple chunks of nested conditional logic. The deeper the nesting and the more bumps, the lower the code health.

Check warning on line 237 in planning/mapless_architecture/autoware_local_mission_planner_common/src/helper_functions.cpp

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)

❌ New issue: Deep, Nested Complexity

GetRelevantAdjacentLanelets has a nested complexity depth of 4, threshold = 4. This function contains deeply nested logic such as if statements and/or loops. The deeper the nesting, the lower the code health.

Check warning on line 616 in planning/mapless_architecture/autoware_local_mission_planner_common/src/helper_functions.cpp

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)

❌ New issue: Deep, Nested Complexity

GetAllNeighborsOfLane has a nested complexity depth of 4, threshold = 4. This function contains deeply nested logic such as if statements and/or loops. The deeper the nesting, the lower the code health.

Check warning on line 1 in planning/mapless_architecture/autoware_local_mission_planner_common/src/helper_functions.cpp

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)

❌ New issue: Primitive Obsession

In this module, 40.4% of all function arguments are primitive types, threshold = 30.0%. The functions in this file have too many primitive types (e.g. int, double, float) in their function argument lists. Using many primitive types lead to the code smell Primitive Obsession. Avoid adding more primitive arguments.

Check warning on line 379 in planning/mapless_architecture/autoware_local_mission_planner_common/src/helper_functions.cpp

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)

❌ New issue: Excess Number of Function Arguments

GetNeighboringLaneletID has 5 arguments, threshold = 4. This function has too many arguments, indicating a lack of encapsulation. Avoid adding more arguments.