-
Notifications
You must be signed in to change notification settings - Fork 691
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: fix Boost.Optional build error on Jazzy #7602
fix: fix Boost.Optional build error on Jazzy #7602
Conversation
Signed-off-by: f0reachARR <f0reach@f0reach.me>
Signed-off-by: f0reachARR <f0reach@f0reach.me>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7602 +/- ##
==========================================
- Coverage 26.86% 26.85% -0.01%
==========================================
Files 1297 1302 +5
Lines 95814 95835 +21
Branches 39144 39137 -7
==========================================
+ Hits 25736 25738 +2
- Misses 67392 67402 +10
- Partials 2686 2695 +9
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Test also worked within my humble environement.
LGTM
Thank you for contributing to the Autoware project! 🚧 If your pull request is in progress, switch it to draft mode. Please ensure:
|
@rej55 @takayuki5168 Could you help approving the planning part? |
Thank you for approving. |
I recently learned the opener of the PR is expected to merge after an approval. Can someone with write permissions merge this since it's approved? |
I just noticed this PR has some conflict, and I fixed it. |
@f0reachARR |
Description
Since Boost 1.79 (maybe), the part that performs IO operations for optional has been separated.
This causes errors when compiling gtest, which will be corrected in this PR.
Ref: https://github.com/orgs/autowarefoundation/discussions/4893
Tests performed
colcon test
passed in both Humble and Jazzy environment.Effects on system behavior
Not applicable.
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.