Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix Boost.Optional build error on Jazzy #7602

Merged
merged 15 commits into from
Oct 10, 2024

Conversation

f0reachARR
Copy link
Contributor

@f0reachARR f0reachARR commented Jun 20, 2024

Description

Since Boost 1.79 (maybe), the part that performs IO operations for optional has been separated.
This causes errors when compiling gtest, which will be corrected in this PR.

Ref: https://github.com/orgs/autowarefoundation/discussions/4893

Tests performed

colcon test passed in both Humble and Jazzy environment.

Effects on system behavior

Not applicable.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: f0reachARR <f0reach@f0reach.me>
Signed-off-by: f0reachARR <f0reach@f0reach.me>
@github-actions github-actions bot added the component:common Common packages from the autoware-common repository. (auto-assigned) label Jun 20, 2024
@f0reachARR f0reachARR changed the title fix: Boost.Optional build error on Jazzy fix: fix Boost.Optional build error on Jazzy Jun 20, 2024
@HansRobo HansRobo added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Jun 20, 2024
Copy link

codecov bot commented Jun 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 26.85%. Comparing base (f49e7a6) to head (79dfc12).
Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7602      +/-   ##
==========================================
- Coverage   26.86%   26.85%   -0.01%     
==========================================
  Files        1297     1302       +5     
  Lines       95814    95835      +21     
  Branches    39144    39137       -7     
==========================================
+ Hits        25736    25738       +2     
- Misses      67392    67402      +10     
- Partials     2686     2695       +9     
Flag Coverage Δ *Carryforward flag
differential 19.46% <ø> (?)
total 26.87% <ø> (+0.01%) ⬆️ Carriedforward from f49e7a6

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@f0reachARR f0reachARR marked this pull request as ready for review June 20, 2024 08:34
Copy link
Contributor

@YoshiRi YoshiRi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test also worked within my humble environement.
LGTM

Copy link

github-actions bot commented Jun 27, 2024

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

@YoshiRi
Copy link
Contributor

YoshiRi commented Aug 13, 2024

@rej55 @takayuki5168 Could you help approving the planning part?

@f0reachARR
Copy link
Contributor Author

Thank you for approving.
Now I merged latest main branch.

@Timple
Copy link
Contributor

Timple commented Sep 30, 2024

I recently learned the opener of the PR is expected to merge after an approval.
But often is lacking rights.

Can someone with write permissions merge this since it's approved?

@f0reachARR
Copy link
Contributor Author

f0reachARR commented Oct 10, 2024

I just noticed this PR has some conflict, and I fixed it.
As you said, I do not have permissions to merge this PR.
Therefore, I would appreciate if someone could merge this PR (after review / CI checks)

@HansRobo HansRobo enabled auto-merge (squash) October 10, 2024 05:14
@HansRobo
Copy link
Member

HansRobo commented Oct 10, 2024

@f0reachARR
I approved CI rus and enabled auto-merge.
If all required CIs are green, this will be merged soon.

@HansRobo HansRobo merged commit 1746798 into autowarefoundation:main Oct 10, 2024
25 of 26 checks passed
@f0reachARR f0reachARR deleted the fix/boost-optional branch October 10, 2024 05:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:common Common packages from the autoware-common repository. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants