feat(pure_pursuit): add polling subscriber #7330
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>
github-actions
bot
added
the
component:control
zulfaqar-azmi-t4
changed the title
zulfaqar-azmi-t4
added
the
run:build-and-test-differential
takayuki5168
approved these changes
Jun 10, 2024
zulfaqar-azmi-t4
merged commit 34307f1
into
autowarefoundation:main
36 of 38 checks passed
zulfaqar-azmi-t4
deleted the
RT1-6699-pure-pursuit-use-polling-subsribers_azu
branch
KhalilSelyan
pushed a commit
that referenced
this pull request
Jul 22, 2024
RT1-6699 add polling subscriber Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Applying polling subscriber based on the discussion.
Tests performed
Change lateral controller to pure_pursuit.
Run PSIM and ensure that vehicle is engaged.
Not applicable.
Effects on system behavior
Nothing but more efficient CPU usage
Not applicable.
Interface changes
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.