feat(raw_vehicle_cmd_converter): use polling subscriber #7319
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sho Iwasawa <sho.iwasawa.2@tier4.jp>
Signed-off-by: Sho Iwasawa <sho.iwasawa.2@tier4.jp>
github-actions
bot
added
type:documentation
zusizusi
added
the
run:build-and-test-differential
shmpwk
reviewed
Jun 9, 2024
|
@zusizusi |
Signed-off-by: Sho Iwasawa <sho.iwasawa.2@tier4.jp>
Signed-off-by: Sho Iwasawa <sho.iwasawa.2@tier4.jp>
…erter Signed-off-by: Sho Iwasawa <sho.iwasawa.2@tier4.jp>
KhalilSelyan
pushed a commit
that referenced
this pull request
Jul 22, 2024
* replace subscription Signed-off-by: Sho Iwasawa <sho.iwasawa.2@tier4.jp> * fix document Signed-off-by: Sho Iwasawa <sho.iwasawa.2@tier4.jp> * sum up functions Signed-off-by: Sho Iwasawa <sho.iwasawa.2@tier4.jp> * add maintainer Signed-off-by: Sho Iwasawa <sho.iwasawa.2@tier4.jp> --------- Signed-off-by: Sho Iwasawa <sho.iwasawa.2@tier4.jp> Co-authored-by: Shumpei Wakabayashi <42209144+shmpwk@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The same as #6997 based on the discussion, the polling subscriber is used in the raw_vehicle_cmd_converter.
Tests performed
Since there was no ROSbag file for the new topic type, I changed the topic type in the code and verified that the topic was output using the ROSbag file of the old topic type.
Effects on system behavior
Nothing but more efficient CPU usage
Interface changes
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.