Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ndt_scan_matcher): componentize NDTScanMatcher #7130

Conversation

a-maumau
Copy link
Contributor

@a-maumau a-maumau commented May 27, 2024

Description

Componentize the node in localization/ndt_scan_matcher.
(Add glog feature to localization/ndt_scan_matcher)

Also, log output is changed from "log" to "both".

Tests performed

Confirmed that terminating the ndt_scan_matcher process will output logs to both the terminal and the log file.

1716789505.9676967 [ndt_scan_matcher_node-39] [INFO] [1716789505.967328818] [rclcpp]: signal_handler(signum=15)
1716789505.9678051 [ndt_scan_matcher_node-39] *** Aborted at 1716789505 (unix time) try "date -d @1716789505" if you are using GNU date ***
1716789505.9685011 [ndt_scan_matcher_node-39] PC: @                0x0 (unknown)
1716789505.9689648 [ndt_scan_matcher_node-39] *** SIGTERM (@0x3e800086304) received by PID 923002 (TID 0x7f8c3bb82680) from PID 549636; stack trace: ***
1716789505.9694099 [ndt_scan_matcher_node-39]     @     0x7f8c3c41f4d6 google::(anonymous namespace)::FailureSignalHandler()
1716789505.9699609 [ndt_scan_matcher_node-39]     @     0x7f8c3c219ded rclcpp::SignalHandler::signal_handler()
1716789505.9704115 [ndt_scan_matcher_node-39]     @     0x7f8c3b842520 (unknown)
1716789505.9708536 [ndt_scan_matcher_node-39]     @     0x7f8c3b8912c0 (unknown)
1716789505.9712942 [ndt_scan_matcher_node-39]     @     0x7f8c3b898002 pthread_mutex_lock
1716789505.9718153 [ndt_scan_matcher_node-39]     @     0x7f8c3c165374 rclcpp::executors::MultiThreadedExecutor::run()
1716789505.9723918 [ndt_scan_matcher_node-39]     @     0x7f8c3c165808 rclcpp::executors::MultiThreadedExecutor::spin()
1716789505.9727521 [ndt_scan_matcher_node-39]     @     0x560a101a3494 main
1716789505.9733877 [ndt_scan_matcher_node-39]     @     0x7f8c3b829d90 (unknown)
1716789505.9738398 [ndt_scan_matcher_node-39]     @     0x7f8c3b829e40 __libc_start_main
1716789505.9738946 [ndt_scan_matcher_node-39]     @     0x560a101a3e45 _start
1716789505.9774137 [ERROR] [ndt_scan_matcher_node-39]: process has died ...

Effects on system behavior

Not applicable.

Interface changes

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

a-maumau added 3 commits May 27, 2024 15:17
Signed-off-by: a-maumau <maumaumaumaumaumaumaumaumaumau@gmail.com>
Signed-off-by: a-maumau <maumaumaumaumaumaumaumaumaumau@gmail.com>
Signed-off-by: a-maumau <maumaumaumaumaumaumaumaumaumau@gmail.com>
@github-actions github-actions bot added the component:localization Vehicle's position determination in its environment. (auto-assigned) label May 27, 2024
@SakodaShintaro SakodaShintaro added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label May 27, 2024
Signed-off-by: a-maumau <maumaumaumaumaumaumaumaumaumau@gmail.com>
Copy link
Contributor

@SakodaShintaro SakodaShintaro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!
Looks Good To Me

@SakodaShintaro SakodaShintaro merged commit 6cb807d into autowarefoundation:main May 27, 2024
22 of 24 checks passed
karishma1911 pushed a commit to Interplai/autoware.universe that referenced this pull request Jun 3, 2024
…on#7130)

* remove unusing main func file

Signed-off-by: a-maumau <maumaumaumaumaumaumaumaumaumau@gmail.com>

* mod to componentize and use glog

Signed-off-by: a-maumau <maumaumaumaumaumaumaumaumaumau@gmail.com>

* change log output from log to both

Signed-off-by: a-maumau <maumaumaumaumaumaumaumaumaumau@gmail.com>

* remove unnecessary

Signed-off-by: a-maumau <maumaumaumaumaumaumaumaumaumau@gmail.com>

---------

Signed-off-by: a-maumau <maumaumaumaumaumaumaumaumaumau@gmail.com>
a-maumau added a commit to a-maumau/autoware.universe that referenced this pull request Jun 7, 2024
…on#7130)

* remove unusing main func file

Signed-off-by: a-maumau <maumaumaumaumaumaumaumaumaumau@gmail.com>

* mod to componentize and use glog

Signed-off-by: a-maumau <maumaumaumaumaumaumaumaumaumau@gmail.com>

* change log output from log to both

Signed-off-by: a-maumau <maumaumaumaumaumaumaumaumaumau@gmail.com>

* remove unnecessary

Signed-off-by: a-maumau <maumaumaumaumaumaumaumaumaumau@gmail.com>

---------

Signed-off-by: a-maumau <maumaumaumaumaumaumaumaumaumau@gmail.com>
@a-maumau a-maumau deleted the mau/feat/localization/ndt_scan_matcher branch July 22, 2024 06:17
KhalilSelyan pushed a commit that referenced this pull request Jul 22, 2024
* remove unusing main func file

Signed-off-by: a-maumau <maumaumaumaumaumaumaumaumaumau@gmail.com>

* mod to componentize and use glog

Signed-off-by: a-maumau <maumaumaumaumaumaumaumaumaumau@gmail.com>

* change log output from log to both

Signed-off-by: a-maumau <maumaumaumaumaumaumaumaumaumau@gmail.com>

* remove unnecessary

Signed-off-by: a-maumau <maumaumaumaumaumaumaumaumaumau@gmail.com>

---------

Signed-off-by: a-maumau <maumaumaumaumaumaumaumaumaumau@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:localization Vehicle's position determination in its environment. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants