Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(crosswalk): fix calclation distance from the null polygons #7122

Merged

Conversation

yuki-takagi-66
Copy link
Contributor

@yuki-takagi-66 yuki-takagi-66 commented May 24, 2024

Description

fix not to calculate the distance from the null polygon

Tests performed

psim and tier4 internal tests

Effects on system behavior

Not applicable.

Interface changes

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: Yuki Takagi <yuki.takagi@tier4.jp>
@yuki-takagi-66 yuki-takagi-66 added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label May 24, 2024
@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label May 24, 2024
Copy link

codecov bot commented May 24, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 15.48%. Comparing base (fe30833) to head (10f8990).
Report is 8 commits behind head on main.

Current head 10f8990 differs from pull request most recent head ce9ad84

Please upload reports for the commit ce9ad84 to get more accurate results.

Files Patch % Lines
..._velocity_crosswalk_module/src/scene_crosswalk.hpp 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #7122   +/-   ##
=======================================
  Coverage   15.48%   15.48%           
=======================================
  Files        1971     1971           
  Lines      136618   136618           
  Branches    44130    44131    +1     
=======================================
  Hits        21154    21154           
  Misses      92252    92252           
  Partials    23212    23212           
Flag Coverage Δ *Carryforward flag
differential 11.53% <0.00%> (?)
total 15.48% <ø> (+<0.01%) ⬆️ Carriedforward from fe30833

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Yuki Takagi <yuki.takagi@tier4.jp>
@yuki-takagi-66 yuki-takagi-66 changed the title fix fix(crosswalk): fix calclation distance from the null polygons May 27, 2024
@yuki-takagi-66 yuki-takagi-66 marked this pull request as ready for review May 27, 2024 06:18
@yuki-takagi-66 yuki-takagi-66 merged commit 6dd2339 into autowarefoundation:main May 27, 2024
24 of 26 checks passed
@yuki-takagi-66 yuki-takagi-66 deleted the crosswalk/check-null-poly branch May 27, 2024 09:42
karishma1911 pushed a commit to Interplai/autoware.universe that referenced this pull request Jun 3, 2024
a-maumau pushed a commit to a-maumau/autoware.universe that referenced this pull request Jun 7, 2024
KhalilSelyan pushed a commit that referenced this pull request Jul 22, 2024
Signed-off-by: Yuki Takagi <yuki.takagi@tier4.jp>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants