Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(multi_object_tracker): revert mot node implementation to composable node components #7117

Merged
merged 4 commits into from
May 27, 2024

Merge branch 'main' into feat/mot-revert-node-impl

50b312e
Select commit
Loading
Failed to load commit list.
Merged

fix(multi_object_tracker): revert mot node implementation to composable node components #7117

Merge branch 'main' into feat/mot-revert-node-impl
50b312e
Select commit
Loading
Failed to load commit list.
CodeScene Delta Analysis / CodeScene Cloud Delta Analysis (main) succeeded May 24, 2024 in 50s

CodeScene PR Check

✅ Code Health Quality Gates: OK

  • Declining Code Health: 1 findings(s) 🚩

View detailed results in CodeScene

Details

🚩 Declining Code Health (highest to lowest):

  • Large Method multi_object_tracker_core.cpp: MultiObjectTracker::MultiObjectTracker

Annotations

Check warning on line 83 in perception/multi_object_tracker/src/multi_object_tracker_core.cpp

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)

❌ Getting worse: Large Method 

MultiObjectTracker::MultiObjectTracker increases from 93 to 97 lines of code, threshold = 70. Large functions with many lines of code are generally harder to understand and lower the code health. Avoid adding more lines to this function.
View more details on CodeScene Delta Analysis