Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(pose_instability_detector): componentize PoseInstabilityDetector #7114

Conversation

a-maumau
Copy link
Contributor

@a-maumau a-maumau commented May 24, 2024

Description

Componentize the node in localization/pose_instability_detector.
(Add glog feature to localization/pose_instability_detector)

Log output is changed from "log" to "both".

Tests performed

Confirmed that killing the pose_instability_detector process will output logs to terminal and log file.

1716533414.7249701 [pose_instability_detector_node-44] [INFO] [1716533414.724666248] [rclcpp]: signal_handler(signum=15)
1716533414.7250943 [pose_instability_detector_node-44] *** Aborted at 1716533414 (unix time) try "date -d @1716533414" if you are using GNU date ***
1716533414.7256374 [pose_instability_detector_node-44] PC: @                0x0 (unknown)
1716533414.7260568 [pose_instability_detector_node-44] *** SIGTERM (@0x3e8001c1f43) received by PID 3205429 (TID 0x7fa97a75f680) from PID 1843011; stack trace: ***
1716533414.7261178 [pose_instability_detector_node-44]     @     0x7fa97affe4d6 google::(anonymous namespace)::FailureSignalHandler()
1716533414.7264707 [pose_instability_detector_node-44]     @     0x7fa97ae19ded rclcpp::SignalHandler::signal_handler()
1716533414.7268443 [pose_instability_detector_node-44]     @     0x7fa97a442520 (unknown)
1716533414.7269030 [pose_instability_detector_node-44]     @     0x7fa97a491117 (unknown)
1716533414.7272096 [pose_instability_detector_node-44]     @     0x7fa97a493e9b pthread_cond_timedwait
1716533414.7272685 [pose_instability_detector_node-44]     @     0x7fa97a384b19 ddsrt_cond_waituntil
1716533414.7273123 [pose_instability_detector_node-44]     @     0x7fa97a36b45d (unknown)
1716533414.7276592 [pose_instability_detector_node-44]     @     0x7fa97a70874f rmw_wait
1716533414.7277162 [pose_instability_detector_node-44]     @     0x7fa97af00848 rcl_wait
1716533414.7280862 [pose_instability_detector_node-44]     @     0x7fa97ad611b6 rclcpp::Executor::wait_for_work()
1716533414.7284558 [pose_instability_detector_node-44]     @     0x7fa97ad616d3 rclcpp::Executor::get_next_executable()
1716533414.7288284 [pose_instability_detector_node-44]     @     0x7fa97ad65c81 rclcpp::executors::SingleThreadedExecutor::spin()
1716533414.7288868 [pose_instability_detector_node-44]     @     0x55ebebebd486 main
1716533414.7295616 [pose_instability_detector_node-44]     @     0x7fa97a429d90 (unknown)
1716533414.7296236 [pose_instability_detector_node-44]     @     0x7fa97a429e40 __libc_start_main
1716533414.7296727 [pose_instability_detector_node-44]     @     0x55ebebebde35 _start
1716533414.7305017 [ERROR] [pose_instability_detector_node-44]: process has died ...

Effects on system behavior

Not applicable.

Interface changes

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

a-maumau added 3 commits May 24, 2024 15:53
Signed-off-by: a-maumau <maumaumaumaumaumaumaumaumaumau@gmail.com>
Signed-off-by: a-maumau <maumaumaumaumaumaumaumaumaumau@gmail.com>
Signed-off-by: a-maumau <maumaumaumaumaumaumaumaumaumau@gmail.com>
@github-actions github-actions bot added the component:localization Vehicle's position determination in its environment. (auto-assigned) label May 24, 2024
@SakodaShintaro SakodaShintaro added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label May 24, 2024
Copy link
Contributor

@SakodaShintaro SakodaShintaro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I also confirmed that logging_simulator and glog work well. 👍
Thank you!

@SakodaShintaro SakodaShintaro enabled auto-merge (squash) May 24, 2024 08:05
@SakodaShintaro SakodaShintaro merged commit 98cc9f2 into autowarefoundation:main May 24, 2024
38 of 39 checks passed
karishma1911 pushed a commit to Interplai/autoware.universe that referenced this pull request Jun 3, 2024
…autowarefoundation#7114)

* remove unusing main func file

Signed-off-by: a-maumau <maumaumaumaumaumaumaumaumaumau@gmail.com>

* mod to componentize and use glog

Signed-off-by: a-maumau <maumaumaumaumaumaumaumaumaumau@gmail.com>

* change log output from log to both

Signed-off-by: a-maumau <maumaumaumaumaumaumaumaumaumau@gmail.com>

---------

Signed-off-by: a-maumau <maumaumaumaumaumaumaumaumaumau@gmail.com>
a-maumau added a commit to a-maumau/autoware.universe that referenced this pull request Jun 7, 2024
…autowarefoundation#7114)

* remove unusing main func file

Signed-off-by: a-maumau <maumaumaumaumaumaumaumaumaumau@gmail.com>

* mod to componentize and use glog

Signed-off-by: a-maumau <maumaumaumaumaumaumaumaumaumau@gmail.com>

* change log output from log to both

Signed-off-by: a-maumau <maumaumaumaumaumaumaumaumaumau@gmail.com>

---------

Signed-off-by: a-maumau <maumaumaumaumaumaumaumaumaumau@gmail.com>
@a-maumau a-maumau deleted the mau/feat/localization/pose_instability_detector branch July 22, 2024 06:17
KhalilSelyan pushed a commit that referenced this pull request Jul 22, 2024
…#7114)

* remove unusing main func file

Signed-off-by: a-maumau <maumaumaumaumaumaumaumaumaumau@gmail.com>

* mod to componentize and use glog

Signed-off-by: a-maumau <maumaumaumaumaumaumaumaumaumau@gmail.com>

* change log output from log to both

Signed-off-by: a-maumau <maumaumaumaumaumaumaumaumaumau@gmail.com>

---------

Signed-off-by: a-maumau <maumaumaumaumaumaumaumaumaumau@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:localization Vehicle's position determination in its environment. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants