Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(pose2twist): componentize Pose2Twist #7113

Conversation

a-maumau
Copy link
Contributor

@a-maumau a-maumau commented May 24, 2024

Description

Componentize the node in localization/pose2twist.
(Add glog feature to localization/pose2twist)

Also, log output is changed from "log" to "both".

Tests performed

Confirmed that killing the pose2twist process will output logs to terminal and log file.

Since it would not get launched from Autoware, use ros2 launch steer_offset_estimator steer_offset_estimator.launch.xml for testing.

1716529333.4860659 [pose2twist_node-1] [INFO] [1716529333.485785831] [rclcpp]: signal_handler(signum=15)
1716529333.4862173 [pose2twist_node-1] *** Aborted at 1716529333 (unix time) try "date -d @1716529333" if you are using GNU date ***
1716529333.4865763 [pose2twist_node-1] PC: @                0x0 (unknown)
1716529333.4867558 [pose2twist_node-1] *** SIGTERM (@0x3e8001c1f43) received by PID 2936661 (TID 0x7f44a8ac1680) from PID 1843011; stack trace: ***
1716529333.4871893 [pose2twist_node-1]     @     0x7f44a935f4d6 google::(anonymous namespace)::FailureSignalHandler()
1716529333.4876823 [pose2twist_node-1]     @     0x7f44a9219ded rclcpp::SignalHandler::signal_handler()
1716529333.4878738 [pose2twist_node-1]     @     0x7f44a8842520 (unknown)
1716529333.4881654 [pose2twist_node-1]     @     0x7f44a8891117 (unknown)
1716529333.4885235 [pose2twist_node-1]     @     0x7f44a8893a41 pthread_cond_wait
1716529333.4885864 [pose2twist_node-1]     @     0x7f44a8784a8d ddsrt_cond_wait
1716529333.4887547 [pose2twist_node-1]     @     0x7f44a8784b55 ddsrt_cond_waituntil
1716529333.4889114 [pose2twist_node-1]     @     0x7f44a876b45d (unknown)
1716529333.4889636 [pose2twist_node-1]     @     0x7f44a8a6a74f rmw_wait
1716529333.4891562 [pose2twist_node-1]     @     0x7f44a8fa0848 rcl_wait
1716529333.4894979 [pose2twist_node-1]     @     0x7f44a91611b6 rclcpp::Executor::wait_for_work()
1716529333.4899106 [pose2twist_node-1]     @     0x7f44a91616d3 rclcpp::Executor::get_next_executable()
1716529333.4902816 [pose2twist_node-1]     @     0x7f44a9165c81 rclcpp::executors::SingleThreadedExecutor::spin()
1716529333.4905012 [pose2twist_node-1]     @     0x556beb94f486 main
1716529333.4907055 [pose2twist_node-1]     @     0x7f44a8829d90 (unknown)
1716529333.4911823 [pose2twist_node-1]     @     0x7f44a8829e40 __libc_start_main
1716529333.4912550 [pose2twist_node-1]     @     0x556beb94fe35 _start
1716529333.4916301 [ERROR] [pose2twist_node-1]: process has died ...

Effects on system behavior

Not applicable.

Interface changes

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

a-maumau added 3 commits May 24, 2024 14:44
Signed-off-by: a-maumau <maumaumaumaumaumaumaumaumaumau@gmail.com>
Signed-off-by: a-maumau <maumaumaumaumaumaumaumaumaumau@gmail.com>
Signed-off-by: a-maumau <maumaumaumaumaumaumaumaumaumau@gmail.com>
@github-actions github-actions bot added the component:localization Vehicle's position determination in its environment. (auto-assigned) label May 24, 2024
@SakodaShintaro SakodaShintaro added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label May 24, 2024
Copy link
Contributor

@SakodaShintaro SakodaShintaro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I confirmed that glog works well 😄
Looks Good To Me

@SakodaShintaro SakodaShintaro merged commit f2ae1af into autowarefoundation:main May 24, 2024
31 of 33 checks passed
karishma1911 pushed a commit to Interplai/autoware.universe that referenced this pull request Jun 3, 2024
* remove unusing main func file

Signed-off-by: a-maumau <maumaumaumaumaumaumaumaumaumau@gmail.com>

* mod to componentize and use glog

Signed-off-by: a-maumau <maumaumaumaumaumaumaumaumaumau@gmail.com>

* change log output from log to both

Signed-off-by: a-maumau <maumaumaumaumaumaumaumaumaumau@gmail.com>

* style(pre-commit): autofix

---------

Signed-off-by: a-maumau <maumaumaumaumaumaumaumaumaumau@gmail.com>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
a-maumau added a commit to a-maumau/autoware.universe that referenced this pull request Jun 7, 2024
* remove unusing main func file

Signed-off-by: a-maumau <maumaumaumaumaumaumaumaumaumau@gmail.com>

* mod to componentize and use glog

Signed-off-by: a-maumau <maumaumaumaumaumaumaumaumaumau@gmail.com>

* change log output from log to both

Signed-off-by: a-maumau <maumaumaumaumaumaumaumaumaumau@gmail.com>

* style(pre-commit): autofix

---------

Signed-off-by: a-maumau <maumaumaumaumaumaumaumaumaumau@gmail.com>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
@a-maumau a-maumau deleted the mau/feat/localization/pose2twist branch July 22, 2024 06:17
KhalilSelyan pushed a commit that referenced this pull request Jul 22, 2024
* remove unusing main func file

Signed-off-by: a-maumau <maumaumaumaumaumaumaumaumaumau@gmail.com>

* mod to componentize and use glog

Signed-off-by: a-maumau <maumaumaumaumaumaumaumaumaumau@gmail.com>

* change log output from log to both

Signed-off-by: a-maumau <maumaumaumaumaumaumaumaumaumau@gmail.com>

* style(pre-commit): autofix

---------

Signed-off-by: a-maumau <maumaumaumaumaumaumaumaumaumau@gmail.com>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:localization Vehicle's position determination in its environment. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants