feat(object_lanelet_filter): add velocity direction based object lanelet filter #7107
CodeScene Delta Analysis / CodeScene Cloud Delta Analysis (main)
succeeded
May 23, 2024 in 44s
CodeScene PR Check
✅ Code Health Quality Gates: OK
- Declining Code Health: 1 findings(s) 🚩
- Improving Code Health: 1 findings(s) ✅
Details
🚩 Declining Code Health (highest to lowest):
- Excess Number of Function Arguments object_lanelet_filter.cpp: ObjectLaneletFilterNode::filterObject
✅ Improving Code Health:
- Complex Method object_lanelet_filter.cpp: ObjectLaneletFilterNode::objectCallback
Annotations
Check notice on line 115 in perception/detected_object_validation/src/object_lanelet_filter.cpp
codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)
✅ No longer an issue: Complex Method
ObjectLaneletFilterNode::objectCallback is no longer above the threshold for cyclomatic complexity. This function has many conditional statements (e.g. if, for, while), leading to lower code health. Avoid adding more conditionals and code to it without refactoring.
Check notice on line 177 in perception/detected_object_validation/src/object_lanelet_filter.cpp
codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)
ℹ New issue: Complex Method
ObjectLaneletFilterNode::filterObject has a cyclomatic complexity of 11, threshold = 9. This function has many conditional statements (e.g. if, for, while), leading to lower code health. Avoid adding more conditionals and code to it without refactoring.
Check warning on line 177 in perception/detected_object_validation/src/object_lanelet_filter.cpp
codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)
❌ New issue: Excess Number of Function Arguments
ObjectLaneletFilterNode::filterObject has 5 arguments, threshold = 4. This function has too many arguments, indicating a lack of encapsulation. Avoid adding more arguments.
Loading