Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(stop_filter): componentize StopFilter #7099

Conversation

a-maumau
Copy link
Contributor

@a-maumau a-maumau commented May 23, 2024

Description

Componentize the node in localization/stop_filter.
(Add glog feature to localization/stop_filter)

Log output is changed from "screen" to "both".

Tests performed

confirmed that killing the stop_filter process will output logs to terminal and log file.

1716456916.0847893 [component_container_mt-57] [INFO] [1716456916.084236188] [control.trajectory_follower.lane_departure_checker_node]: waiting for route msg...
1716456918.1749604 [stop_filter_node-42] [INFO] [1716456918.174565969] [rclcpp]: signal_handler(signum=15)
1716456918.1751084 [stop_filter_node-42] *** Aborted at 1716456918 (unix time) try "date -d @1716456918" if you are using GNU date ***
1716456918.1757030 [stop_filter_node-42] PC: @                0x0 (unknown)
1716456918.1757896 [stop_filter_node-42] *** SIGTERM (@0x3e8001c1f43) received by PID 1192177 (TID 0x7f35ada78680) from PID 1843011; stack trace: ***
1716456918.1762626 [stop_filter_node-42]     @     0x7f35ae3164d6 google::(anonymous namespace)::FailureSignalHandler()
1716456918.1766379 [stop_filter_node-42]     @     0x7f35ae219ded rclcpp::SignalHandler::signal_handler()
1716456918.1771111 [stop_filter_node-42]     @     0x7f35ad842520 (unknown)
1716456918.1771710 [stop_filter_node-42]     @     0x7f35ad891117 (unknown)
1716456918.1772175 [stop_filter_node-42]     @     0x7f35ad893a41 pthread_cond_wait
1716456918.1772585 [stop_filter_node-42]     @     0x7f35ad716a8d ddsrt_cond_wait
1716456918.1776760 [stop_filter_node-42]     @     0x7f35ad716b55 ddsrt_cond_waituntil
1716456918.1777370 [stop_filter_node-42]     @     0x7f35ad6fd45d (unknown)
1716456918.1777802 [stop_filter_node-42]     @     0x7f35ad7b974f rmw_wait
1716456918.1781502 [stop_filter_node-42]     @     0x7f35adf57848 rcl_wait
1716456918.1784594 [stop_filter_node-42]     @     0x7f35ae1611b6 rclcpp::Executor::wait_for_work()
1716456918.1788106 [stop_filter_node-42]     @     0x7f35ae1616d3 rclcpp::Executor::get_next_executable()
1716456918.1791706 [stop_filter_node-42]     @     0x7f35ae165c81 rclcpp::executors::SingleThreadedExecutor::spin()
1716456918.1792378 [stop_filter_node-42]     @     0x562f91c6f486 main
1716456918.1795518 [stop_filter_node-42]     @     0x7f35ad829d90 (unknown)
1716456918.1796126 [stop_filter_node-42]     @     0x7f35ad829e40 __libc_start_main
1716456918.1796575 [stop_filter_node-42]     @     0x562f91c6fe35 _start
1716456918.1809032 [ERROR] [stop_filter_node-42]: process has died ...

Not applicable.

Effects on system behavior

Not applicable.

Interface changes

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

a-maumau added 2 commits May 23, 2024 11:42
Signed-off-by: a-maumau <maumaumaumaumaumaumaumaumaumau@gmail.com>
Signed-off-by: a-maumau <maumaumaumaumaumaumaumaumaumau@gmail.com>
@github-actions github-actions bot added the component:localization Vehicle's position determination in its environment. (auto-assigned) label May 23, 2024
Copy link
Contributor

@SakodaShintaro SakodaShintaro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much!
I have confirmed that the logging_simulator works properly and that glog works properly when using the tier4 version of rclcpp.

@SakodaShintaro SakodaShintaro added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label May 23, 2024
@SakodaShintaro SakodaShintaro self-requested a review May 23, 2024 09:05
a-maumau added 2 commits May 23, 2024 18:37
Signed-off-by: a-maumau <maumaumaumaumaumaumaumaumaumau@gmail.com>
Signed-off-by: a-maumau <maumaumaumaumaumaumaumaumaumau@gmail.com>
@a-maumau a-maumau changed the title feat(stop_filter): add glog to StopFilter feat(stop_filter): componentize StopFilter May 23, 2024
@SakodaShintaro SakodaShintaro self-requested a review May 24, 2024 00:15
Copy link
Contributor

@SakodaShintaro SakodaShintaro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks Good To Me

@SakodaShintaro SakodaShintaro enabled auto-merge (squash) May 24, 2024 00:16
@SakodaShintaro SakodaShintaro merged commit 8281d7f into autowarefoundation:main May 24, 2024
27 of 28 checks passed
karishma1911 pushed a commit to Interplai/autoware.universe that referenced this pull request Jun 3, 2024
* remove unused main func file

Signed-off-by: a-maumau <maumaumaumaumaumaumaumaumaumau@gmail.com>

* add and mod to use glog

Signed-off-by: a-maumau <maumaumaumaumaumaumaumaumaumau@gmail.com>

* rm dependencies

Signed-off-by: a-maumau <maumaumaumaumaumaumaumaumaumau@gmail.com>

* change log output from screen to both

Signed-off-by: a-maumau <maumaumaumaumaumaumaumaumaumau@gmail.com>

---------

Signed-off-by: a-maumau <maumaumaumaumaumaumaumaumaumau@gmail.com>
a-maumau added a commit to a-maumau/autoware.universe that referenced this pull request Jun 7, 2024
* remove unused main func file

Signed-off-by: a-maumau <maumaumaumaumaumaumaumaumaumau@gmail.com>

* add and mod to use glog

Signed-off-by: a-maumau <maumaumaumaumaumaumaumaumaumau@gmail.com>

* rm dependencies

Signed-off-by: a-maumau <maumaumaumaumaumaumaumaumaumau@gmail.com>

* change log output from screen to both

Signed-off-by: a-maumau <maumaumaumaumaumaumaumaumaumau@gmail.com>

---------

Signed-off-by: a-maumau <maumaumaumaumaumaumaumaumaumau@gmail.com>
@a-maumau a-maumau deleted the mau/fix/localization/stop_filter branch July 22, 2024 06:17
KhalilSelyan pushed a commit that referenced this pull request Jul 22, 2024
* remove unused main func file

Signed-off-by: a-maumau <maumaumaumaumaumaumaumaumaumau@gmail.com>

* add and mod to use glog

Signed-off-by: a-maumau <maumaumaumaumaumaumaumaumaumau@gmail.com>

* rm dependencies

Signed-off-by: a-maumau <maumaumaumaumaumaumaumaumaumau@gmail.com>

* change log output from screen to both

Signed-off-by: a-maumau <maumaumaumaumaumaumaumaumaumau@gmail.com>

---------

Signed-off-by: a-maumau <maumaumaumaumaumaumaumaumaumau@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:localization Vehicle's position determination in its environment. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants