-
Notifications
You must be signed in to change notification settings - Fork 700
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(stop_filter): componentize StopFilter #7099
feat(stop_filter): componentize StopFilter #7099
Conversation
Signed-off-by: a-maumau <maumaumaumaumaumaumaumaumaumau@gmail.com>
Signed-off-by: a-maumau <maumaumaumaumaumaumaumaumaumau@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you very much!
I have confirmed that the logging_simulator works properly and that glog works properly when using the tier4 version of rclcpp.
Signed-off-by: a-maumau <maumaumaumaumaumaumaumaumaumau@gmail.com>
Signed-off-by: a-maumau <maumaumaumaumaumaumaumaumaumau@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks Good To Me
8281d7f
into
autowarefoundation:main
* remove unused main func file Signed-off-by: a-maumau <maumaumaumaumaumaumaumaumaumau@gmail.com> * add and mod to use glog Signed-off-by: a-maumau <maumaumaumaumaumaumaumaumaumau@gmail.com> * rm dependencies Signed-off-by: a-maumau <maumaumaumaumaumaumaumaumaumau@gmail.com> * change log output from screen to both Signed-off-by: a-maumau <maumaumaumaumaumaumaumaumaumau@gmail.com> --------- Signed-off-by: a-maumau <maumaumaumaumaumaumaumaumaumau@gmail.com>
* remove unused main func file Signed-off-by: a-maumau <maumaumaumaumaumaumaumaumaumau@gmail.com> * add and mod to use glog Signed-off-by: a-maumau <maumaumaumaumaumaumaumaumaumau@gmail.com> * rm dependencies Signed-off-by: a-maumau <maumaumaumaumaumaumaumaumaumau@gmail.com> * change log output from screen to both Signed-off-by: a-maumau <maumaumaumaumaumaumaumaumaumau@gmail.com> --------- Signed-off-by: a-maumau <maumaumaumaumaumaumaumaumaumau@gmail.com>
* remove unused main func file Signed-off-by: a-maumau <maumaumaumaumaumaumaumaumaumau@gmail.com> * add and mod to use glog Signed-off-by: a-maumau <maumaumaumaumaumaumaumaumaumau@gmail.com> * rm dependencies Signed-off-by: a-maumau <maumaumaumaumaumaumaumaumaumau@gmail.com> * change log output from screen to both Signed-off-by: a-maumau <maumaumaumaumaumaumaumaumaumau@gmail.com> --------- Signed-off-by: a-maumau <maumaumaumaumaumaumaumaumaumau@gmail.com>
Description
Componentize the node in localization/stop_filter.
(Add glog feature to localization/stop_filter)
Log output is changed from "screen" to "both".
Tests performed
confirmed that killing the stop_filter process will output logs to terminal and log file.
Not applicable.
Effects on system behavior
Not applicable.
Interface changes
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.