Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: perception objects pointcloud better visualization #7095

Closed

chore: add check for empty pointcloud before calling setInputCloud

69525aa
Select commit
Loading
Failed to load commit list.
Closed

feat: perception objects pointcloud better visualization #7095

chore: add check for empty pointcloud before calling setInputCloud
69525aa
Select commit
Loading
Failed to load commit list.
CodeScene Delta Analysis / CodeScene Cloud Delta Analysis (main) failed Jul 1, 2024 in 4m 56s

CodeScene PR Check

Code Health Quality Gates: FAILED

Change in average Code Health of affected files: -0.56 (8.82 -> 8.25)

  • Declining Code Health: 2 findings(s) 🚩

View detailed results in CodeScene

Absence of Expected Change Pattern

  • autoware.universe/common/autoware_perception_rviz_plugin/src/object_detection/predicted_objects_display.cpp is usually changed with: autoware.universe/common/autoware_perception_rviz_plugin/src/object_detection/tracked_objects_display.cpp

Details

🚩 Declining Code Health (highest to lowest):

  • Complex Method predicted_objects_display.cpp: PredictedObjectsDisplay::createMarkers
  • Overall Code Complexity predicted_objects_display.cpp

Annotations

Check warning on line 272 in common/autoware_perception_rviz_plugin/src/object_detection/predicted_objects_display.cpp

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)

❌ Getting worse: Complex Method

PredictedObjectsDisplay::createMarkers increases in cyclomatic complexity from 20 to 21, threshold = 9. This function has many conditional statements (e.g. if, for, while), leading to lower code health. Avoid adding more conditionals and code to it without refactoring.

Check warning on line 1 in common/autoware_perception_rviz_plugin/src/object_detection/predicted_objects_display.cpp

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)

❌ New issue: Overall Code Complexity

This module has a mean cyclomatic complexity of 5.50 across 8 functions. The mean complexity threshold is 4. This file has many conditional statements (e.g. if, for, while) across its implementation, leading to lower code health. Avoid adding more conditionals.