Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(automatic_pose_initializer): fix plugin name #7035

Conversation

SakodaShintaro
Copy link
Contributor

Description

automatic_pose_initializer is changed as a plugin in the pull request below, but it is not launched because the name is incorrect, causing an issue where autoware cannot start automatic initial pose estimation.

Tests performed

logging_simulator works well.

Effects on system behavior

Initial pose estimation starts successfully.

Interface changes

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: Shintaro Sakoda <shintaro.sakoda@tier4.jp>
@SakodaShintaro SakodaShintaro added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label May 16, 2024
@SakodaShintaro SakodaShintaro self-assigned this May 16, 2024
@github-actions github-actions bot added the component:system System design and integration. (auto-assigned) label May 16, 2024
@SakodaShintaro SakodaShintaro enabled auto-merge (squash) May 16, 2024 07:52
Copy link
Contributor

@yukkysaito yukkysaito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@SakodaShintaro SakodaShintaro merged commit de53828 into autowarefoundation:main May 16, 2024
34 checks passed
@SakodaShintaro SakodaShintaro deleted the fix/automatic_pose_initializer_plugin_name branch May 16, 2024 07:56
karishma1911 pushed a commit to Interplai/autoware.universe that referenced this pull request Jun 3, 2024
…7035)

Fixed automatic_pose_initializer plugin name

Signed-off-by: Shintaro Sakoda <shintaro.sakoda@tier4.jp>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:system System design and integration. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants