Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(lidar_centerpoint): add test #7029

Merged
merged 7 commits into from
May 17, 2024
Merged

Conversation

kminoda
Copy link
Contributor

@kminoda kminoda commented May 15, 2024

Description

Add test for some of the files in lidar_centerpoint

Tests performed

Confirmed that the test passes

Effects on system behavior

None

Interface changes

None

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

kminoda added 2 commits May 15, 2024 22:28
Signed-off-by: kminoda <koji.minoda@tier4.jp>
Signed-off-by: kminoda <koji.minoda@tier4.jp>
@kminoda kminoda force-pushed the test/lidar_centerpoint/add_test branch from b20656c to 1949f95 Compare May 15, 2024 13:51
Signed-off-by: kminoda <koji.minoda@tier4.jp>
@kminoda kminoda marked this pull request as ready for review May 15, 2024 13:52
@kminoda kminoda requested a review from knzo25 as a code owner May 15, 2024 13:52
@kminoda kminoda added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label May 15, 2024
pre-commit-ci bot and others added 3 commits May 15, 2024 13:53
@github-actions github-actions bot added the component:perception Advanced sensor data processing and environment understanding. (auto-assigned) label May 15, 2024
Copy link
Contributor

@knzo25 knzo25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
(did not find anything to comment on, but will do testing for the pre/post processing later unless someone was already doing it)

@kminoda kminoda merged commit 5105e83 into main May 17, 2024
22 of 23 checks passed
@kminoda kminoda deleted the test/lidar_centerpoint/add_test branch May 17, 2024 10:22
karishma1911 pushed a commit to Interplai/autoware.universe that referenced this pull request Jun 3, 2024
* test(lidar_centerpoint): add test

Signed-off-by: kminoda <koji.minoda@tier4.jp>

* update test

Signed-off-by: kminoda <koji.minoda@tier4.jp>

* update license

Signed-off-by: kminoda <koji.minoda@tier4.jp>

* style(pre-commit): autofix

* fix namespace

Signed-off-by: kminoda <koji.minoda@tier4.jp>

* style(pre-commit): autofix

---------

Signed-off-by: kminoda <koji.minoda@tier4.jp>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:perception Advanced sensor data processing and environment understanding. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants