Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(diagnostic_graph_aggregator): componentize node #7025

Conversation

isamu-takagi
Copy link
Contributor

@isamu-takagi isamu-takagi commented May 15, 2024

Description

Componentize node in diagnostic_graph_aggregator.

Tests performed

Not applicable.

Effects on system behavior

Not applicable.

Interface changes

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>
@isamu-takagi isamu-takagi self-assigned this May 15, 2024
@github-actions github-actions bot added the component:system System design and integration. (auto-assigned) label May 15, 2024
Copy link
Contributor

@TetsuKawa TetsuKawa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@isamu-takagi isamu-takagi enabled auto-merge (squash) May 15, 2024 10:17
@isamu-takagi isamu-takagi added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label May 15, 2024
@isamu-takagi isamu-takagi merged commit 85fdcb0 into autowarefoundation:main May 15, 2024
37 of 39 checks passed
vividf pushed a commit to vividf/autoware.universe that referenced this pull request May 16, 2024
…ion#7025)

Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>
Signed-off-by: vividf <yihsiang.fang@tier4.jp>
@isamu-takagi isamu-takagi deleted the feat/componentize-diag-graph-agg branch May 17, 2024 01:12
karishma1911 pushed a commit to Interplai/autoware.universe that referenced this pull request Jun 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:system System design and integration. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants