-
Notifications
You must be signed in to change notification settings - Fork 696
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(pointcloud_preprocessor): calculate visibility score in ring outlier filter #7011
Merged
kyoichi-sugahara
merged 5 commits into
autowarefoundation:main
from
kyoichi-sugahara:feat/calculate_visibility_score_ring_outlier_filter
May 17, 2024
Merged
feat(pointcloud_preprocessor): calculate visibility score in ring outlier filter #7011
kyoichi-sugahara
merged 5 commits into
autowarefoundation:main
from
kyoichi-sugahara:feat/calculate_visibility_score_ring_outlier_filter
May 17, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>
8ef4df8
to
35da49d
Compare
35da49d
to
e843b53
Compare
Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>
e843b53
to
1d09b20
Compare
Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>
Can you add an algorithm summary to the readme? |
…_filter Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>
Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>
@yukkysaito |
yukkysaito
approved these changes
May 17, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
81a75f7
into
autowarefoundation:main
32 of 35 checks passed
karishma1911
pushed a commit
to Interplai/autoware.universe
that referenced
this pull request
Jun 3, 2024
…lier filter (autowarefoundation#7011) * calculate visibility score in ring outlier filter Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp> --------- Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
component:sensing
Data acquisition from sensors, drivers, preprocessing. (auto-assigned)
run:build-and-test-differential
Mark to enable build-and-test-differential workflow. (used-by-ci)
type:documentation
Creating or refining documentation. (auto-assigned)
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
calculate visibility score based on oulier pointcloud.
This feature is disabled by default with
publish_outlier_pointcloud
Tests performed
get the following result
Effects on system behavior
not applicable
Interface changes
not applicable
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.