Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(turn_signal_decider): straddle bound method #7006

Conversation

danielsanchezaran
Copy link
Contributor

@danielsanchezaran danielsanchezaran commented May 14, 2024

Description

Refactor to make the code a little bit more clean and comply more with C++ iterators

Tests performed

PSim

Effects on system behavior

Not applicable.

Interface changes

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com>
@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label May 14, 2024
@danielsanchezaran danielsanchezaran marked this pull request as ready for review May 14, 2024 06:22
@danielsanchezaran danielsanchezaran added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label May 14, 2024
Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com>
Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com>
Copy link
Contributor

@zulfaqar-azmi-t4 zulfaqar-azmi-t4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@danielsanchezaran danielsanchezaran enabled auto-merge (squash) May 14, 2024 07:33
@danielsanchezaran danielsanchezaran merged commit a4bb177 into autowarefoundation:main May 14, 2024
21 of 22 checks passed
@danielsanchezaran danielsanchezaran deleted the refactor/turn_signal_decider_straddle_road branch May 14, 2024 10:07
vividf pushed a commit to vividf/autoware.universe that referenced this pull request May 16, 2024
…ion#7006)

* refactor straddle bound method

Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com>

* remove parenthesis

Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com>

* add alias for inner lambda

Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com>

---------

Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com>
Signed-off-by: vividf <yihsiang.fang@tier4.jp>
karishma1911 pushed a commit to Interplai/autoware.universe that referenced this pull request Jun 3, 2024
…ion#7006)

* refactor straddle bound method

Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com>

* remove parenthesis

Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com>

* add alias for inner lambda

Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com>

---------

Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com>
satoshi-ota pushed a commit to tier4/autoware.universe that referenced this pull request Jun 6, 2024
…ion#7006)

* refactor straddle bound method

Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com>

* remove parenthesis

Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com>

* add alias for inner lambda

Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com>

---------

Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants