refactor(turn_signal_decider): straddle bound method #7006
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com>
github-actions
bot
added
the
component:planning
danielsanchezaran
requested review from
rej55,
go-sakayori,
kosuke55,
soblin,
maxime-clem,
satoshi-ota,
shmpwk,
TakaHoribe,
takayuki5168,
tkimura4 and
zulfaqar-azmi-t4
as code owners
danielsanchezaran
added
the
run:build-and-test-differential
Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com>
maxime-clem
approved these changes
May 14, 2024
Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com>
danielsanchezaran
merged commit a4bb177
into
autowarefoundation:main
21 of 22 checks passed
vividf
pushed a commit
to vividf/autoware.universe
that referenced
this pull request
May 16, 2024
…ion#7006) * refactor straddle bound method Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com> * remove parenthesis Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com> * add alias for inner lambda Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com> --------- Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com> Signed-off-by: vividf <yihsiang.fang@tier4.jp>
karishma1911
pushed a commit
to Interplai/autoware.universe
that referenced
this pull request
Jun 3, 2024
…ion#7006) * refactor straddle bound method Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com> * remove parenthesis Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com> * add alias for inner lambda Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com> --------- Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com>
satoshi-ota
pushed a commit
to tier4/autoware.universe
that referenced
this pull request
Jun 6, 2024
…ion#7006) * refactor straddle bound method Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com> * remove parenthesis Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com> * add alias for inner lambda Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com> --------- Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Refactor to make the code a little bit more clean and comply more with C++ iterators
Tests performed
PSim
Effects on system behavior
Not applicable.
Interface changes
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.