Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(autoware_planning_test_manager): rename package #6995

Add route handler back into package.xml

144ea39
Select commit
Loading
Failed to load commit list.
Merged

refactor(autoware_planning_test_manager): rename package #6995

Add route handler back into package.xml
144ea39
Select commit
Loading
Failed to load commit list.
CodeScene Delta Analysis / CodeScene Cloud Delta Analysis (main) succeeded May 14, 2024 in 31s

CodeScene PR Check

Code Health Quality Gates: OK

  • Declining Code Health: 2 findings(s) 🚩

View detailed results in CodeScene

Details

🚩 Declining Code Health (highest to lowest):

  • Primitive Obsession autoware_planning_test_manager.cpp
  • String Heavy Function Arguments autoware_planning_test_manager.cpp

Annotations

Check warning on line 1 in planning/autoware_planning_test_manager/src/autoware_planning_test_manager.cpp

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)

❌ New issue: Primitive Obsession

In this module, 45.3% of all function arguments are primitive types, threshold = 30.0%. The functions in this file have too many primitive types (e.g. int, double, float) in their function argument lists. Using many primitive types lead to the code smell Primitive Obsession. Avoid adding more primitive arguments.

Check warning on line 1 in planning/autoware_planning_test_manager/src/autoware_planning_test_manager.cpp

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)

❌ New issue: String Heavy Function Arguments

In this module, 43.2% of all arguments to its 62 functions are strings. The threshold for string arguments is 39.0%. The functions in this file have a high ratio of strings as arguments. Avoid adding more.