Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(accel_brake_map_calibrator): fix accel_brake_map_calibrator not to output invalid maps #6992

Merged
merged 1 commit into from
May 13, 2024

fix(accel_brake_map_calibrator): fix accel_brake_map_calibrator not t…

4cf7f0d
Select commit
Loading
Failed to load commit list.
Merged

fix(accel_brake_map_calibrator): fix accel_brake_map_calibrator not to output invalid maps #6992

fix(accel_brake_map_calibrator): fix accel_brake_map_calibrator not t…
4cf7f0d
Select commit
Loading
Failed to load commit list.
CodeScene Delta Analysis / CodeScene Cloud Delta Analysis (main) succeeded May 13, 2024 in 47s

CodeScene PR Check

Code Health Quality Gates: OK

View detailed results in CodeScene

Details

Annotations

Check notice on line 1 in vehicle/accel_brake_map_calibrator/src/accel_brake_map_calibrator_node.cpp

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)

ℹ Getting worse: Lines of Code in a Single File

The lines of code increases from 1361 to 1362, improve code health by reducing it to 1000. The number of Lines of Code in a single file. More Lines of Code lowers the code health.

Check notice on line 1 in vehicle/accel_brake_map_calibrator/src/accel_brake_map_calibrator_node.cpp

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)

ℹ Getting worse: Overall Code Complexity

The mean cyclomatic complexity increases from 4.04 to 4.06, threshold = 4. This file has many conditional statements (e.g. if, for, while) across its implementation, leading to lower code health. Avoid adding more conditionals.