-
Notifications
You must be signed in to change notification settings - Fork 696
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(behavior_velocity_occlusion_spot_module): reduce cppcheck warning #6987
Merged
shmpwk
merged 8 commits into
autowarefoundation:main
from
veqcc:refactor/behavior_velocity_occlusion_spot_module
May 14, 2024
Merged
refactor(behavior_velocity_occlusion_spot_module): reduce cppcheck warning #6987
shmpwk
merged 8 commits into
autowarefoundation:main
from
veqcc:refactor/behavior_velocity_occlusion_spot_module
May 14, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ryuta Kambe <ryuta.kambe@tier4.jp>
Signed-off-by: Ryuta Kambe <ryuta.kambe@tier4.jp>
Signed-off-by: Ryuta Kambe <ryuta.kambe@tier4.jp>
Signed-off-by: Ryuta Kambe <ryuta.kambe@tier4.jp>
Signed-off-by: Ryuta Kambe <ryuta.kambe@tier4.jp>
Signed-off-by: Ryuta Kambe <ryuta.kambe@tier4.jp>
@veqcc |
Signed-off-by: Ryuta Kambe <ryuta.kambe@tier4.jp>
Could anyone give it an approve? |
4 tasks
shmpwk
approved these changes
May 14, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you so much!
vividf
pushed a commit
to vividf/autoware.universe
that referenced
this pull request
May 16, 2024
…rning (autowarefoundation#6987) * remove unnecessary if branch Signed-off-by: Ryuta Kambe <ryuta.kambe@tier4.jp> * add const for const variable Signed-off-by: Ryuta Kambe <ryuta.kambe@tier4.jp> * remove redundant assignment Signed-off-by: Ryuta Kambe <ryuta.kambe@tier4.jp> * remove redundant if branch Signed-off-by: Ryuta Kambe <ryuta.kambe@tier4.jp> * underflow check Signed-off-by: Ryuta Kambe <ryuta.kambe@tier4.jp> * use const for const parameter Signed-off-by: Ryuta Kambe <ryuta.kambe@tier4.jp> * style(pre-commit): autofix * delete unnecessary pointsToRays function Signed-off-by: Ryuta Kambe <ryuta.kambe@tier4.jp> --------- Signed-off-by: Ryuta Kambe <ryuta.kambe@tier4.jp> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Signed-off-by: vividf <yihsiang.fang@tier4.jp>
karishma1911
pushed a commit
to Interplai/autoware.universe
that referenced
this pull request
Jun 3, 2024
…rning (autowarefoundation#6987) * remove unnecessary if branch Signed-off-by: Ryuta Kambe <ryuta.kambe@tier4.jp> * add const for const variable Signed-off-by: Ryuta Kambe <ryuta.kambe@tier4.jp> * remove redundant assignment Signed-off-by: Ryuta Kambe <ryuta.kambe@tier4.jp> * remove redundant if branch Signed-off-by: Ryuta Kambe <ryuta.kambe@tier4.jp> * underflow check Signed-off-by: Ryuta Kambe <ryuta.kambe@tier4.jp> * use const for const parameter Signed-off-by: Ryuta Kambe <ryuta.kambe@tier4.jp> * style(pre-commit): autofix * delete unnecessary pointsToRays function Signed-off-by: Ryuta Kambe <ryuta.kambe@tier4.jp> --------- Signed-off-by: Ryuta Kambe <ryuta.kambe@tier4.jp> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
component:planning
Route planning, decision-making, and navigation. (auto-assigned)
run:build-and-test-differential
Mark to enable build-and-test-differential workflow. (used-by-ci)
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is based on CppCheck warnings.
30b90a3
b9fcb38
06acd45
d740ae0
underflow check
da77325
use const for const parameter
eca35cd
Question
If the first commit (about
polys
) is acceptable, then the functionpointsToRays
seems unnecessary anymore.Do you think I should delete it too?
autoware.universe/planning/behavior_velocity_occlusion_spot_module/src/grid_utils.cpp
Line 108 in fd6306d
Tests performed
No
Effects on system behavior
Interface changes
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.