Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(behavior_velocity_no_stopping_area_module): cppcheck warnings #6986

Merged
merged 3 commits into from
May 21, 2024
Merged

refactor(behavior_velocity_no_stopping_area_module): cppcheck warnings #6986

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e0e49be
remove redundant if branch
veqcc May 12, 2024
021129a
remove unused variable
veqcc May 12, 2024
0eb34eb
remove redundant initialization
veqcc May 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
remove redundant if branch 
Signed-off-by: Ryuta Kambe <ryuta.kambe@tier4.jp>
  • Loading branch information
@veqcc
veqcc committed May 12, 2024
commit e0e49be0b07240e9c2097ed726397badeb983dfd
5 changes: 1 addition & 4 deletions planning/behavior_velocity_no_stopping_area_module/src/scene_no_stopping_area.cpp
View file
Original file line number Diff line number Diff line change
@@ -87,11 +87,8 @@ boost::optional<LineString2d> NoStoppingAreaModule::getStopLineGeometry2d(
const LineString2d line{{p0.x, p0.y}, {p1.x, p1.y}};
std::vector<Point2d> collision_points;
bg::intersection(area_poly, line, collision_points);
if (collision_points.empty()) {
continue;
}
const double yaw = tier4_autoware_utils::calcAzimuthAngle(p0, p1);
if (!collision_points.empty()) {
const double yaw = tier4_autoware_utils::calcAzimuthAngle(p0, p1);
geometry_msgs::msg::Point left_point;
const double w = planner_data_->vehicle_info_.vehicle_width_m;
const double l = stop_line_margin;