refactor(mission_planner): remove redundant is_reroute check
#6980
CodeScene Delta Analysis / CodeScene Cloud Delta Analysis (main)
succeeded
May 11, 2024 in 34s
CodeScene PR Check
✅ Code Health Quality Gates: OK
- Improving Code Health: 3 findings(s) ✅
Details
✅ Improving Code Health:
- Overall Code Complexity mission_planner.cpp
- Complex Method mission_planner.cpp: MissionPlanner::on_set_waypoint_route
- Complex Method mission_planner.cpp: MissionPlanner::on_set_lanelet_route
Annotations
Check notice on line 301 in planning/mission_planner/src/mission_planner/mission_planner.cpp
codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)
✅ Getting better: Complex Method
MissionPlanner::on_set_waypoint_route decreases in cyclomatic complexity from 19 to 18, threshold = 9. This function has many conditional statements (e.g. if, for, while), leading to lower code health. Avoid adding more conditionals and code to it without refactoring.
Check notice on line 253 in planning/mission_planner/src/mission_planner/mission_planner.cpp
codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)
✅ Getting better: Complex Method
MissionPlanner::on_set_lanelet_route decreases in cyclomatic complexity from 19 to 18, threshold = 9. This function has many conditional statements (e.g. if, for, while), leading to lower code health. Avoid adding more conditionals and code to it without refactoring.
Check notice on line 1 in planning/mission_planner/src/mission_planner/mission_planner.cpp
codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)
✅ Getting better: Overall Code Complexity
The mean cyclomatic complexity decreases from 4.76 to 4.67, threshold = 4. This file has many conditional statements (e.g. if, for, while) across its implementation, leading to lower code health. Avoid adding more conditionals.
Loading