-
Notifications
You must be signed in to change notification settings - Fork 699
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(tier4_calibration_rviz_plugin): fix to set service name and exception failure #6973
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!!
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #6973 +/- ##
========================================
Coverage 15.38% 15.39%
========================================
Files 1908 1908
Lines 133256 133146 -110
Branches 42309 42307 -2
========================================
- Hits 20496 20492 -4
+ Misses 90008 89903 -105
+ Partials 22752 22751 -1
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. |
…ilure (autowarefoundation#6973) * add service * fix exception * fix style
…ilure (autowarefoundation#6973) * add service * fix exception * fix style Signed-off-by: vividf <yihsiang.fang@tier4.jp>
…ilure (autowarefoundation#6973) * add service * fix exception * fix style
Description
I'll fix below
//accel_brake_calibrator/outout/update_suggest
Related links
Tests performed
I confirmed their behavior with accel_brake_map_calibrator, rqt and rviz...
output-2024-05-10_17.04.33.mp4
Notes for reviewers
Interface changes
ROS Topic Changes
ROS Parameter Changes
Effects on system behavior
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.