Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(map_based_prediction): revert use different time horizon (#6877) #6970

Merged
merged 1 commit into from
May 10, 2024

Conversation

YoshiRi
Copy link
Contributor

@YoshiRi YoshiRi commented May 10, 2024

Description

This reverts commit d5aa5d6.

Tests performed

Not applicable.

Effects on system behavior

Not applicable.

Interface changes

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

This reverts commit d5aa5d6.

Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com>
@github-actions github-actions bot added the component:perception Advanced sensor data processing and environment understanding. (auto-assigned) label May 10, 2024
@YoshiRi YoshiRi changed the title Revert "feat(map_based_prediction): use different time horizon (#6877)" fix(map_based_prediction): revert use different time horizon (#6877) May 10, 2024
@satoshi-ota satoshi-ota added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label May 10, 2024
@YoshiRi YoshiRi merged commit 885c0af into main May 10, 2024
33 of 36 checks passed
@YoshiRi YoshiRi deleted the chore/revert_PR6877 branch May 10, 2024 06:57
vividf pushed a commit to vividf/autoware.universe that referenced this pull request May 16, 2024
…efoundation#6877) (autowarefoundation#6970)

Revert "feat(map_based_prediction): use different time horizon (autowarefoundation#6877)"

This reverts commit d5aa5d6.

Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com>
Signed-off-by: vividf <yihsiang.fang@tier4.jp>
@kminoda
Copy link
Contributor

kminoda commented May 18, 2024

@YoshiRi Hi, why was the #6877 PR reverted? There were some bugs in it? (I was considering writing a test for the node, and wondering if I could write a test that addresses a bug if any)

@soblin
Copy link
Contributor

soblin commented May 18, 2024

Because it caused unintended fail in our planning scenarios. I'll handle this again when it's ready.

karishma1911 pushed a commit to Interplai/autoware.universe that referenced this pull request Jun 3, 2024
…efoundation#6877) (autowarefoundation#6970)

Revert "feat(map_based_prediction): use different time horizon (autowarefoundation#6877)"

This reverts commit d5aa5d6.

Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:perception Advanced sensor data processing and environment understanding. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants