refactor(pointcloud_preprocessor): move roi_mode_map_ definition inside DualReturnOutlierFilterComponent class #6654
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… class Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>
kyoichi-sugahara
requested review from
amc-nu,
badai-nguyen,
miursh and
yukkysaito
as code owners
github-actions
bot
added
the
component:sensing
|
@badai-nguyen |
badai-nguyen
approved these changes
Mar 20, 2024
kyoichi-sugahara
added
the
run:build-and-test-differential
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6654 +/- ##
=======================================
Coverage 14.78% 14.78%
=======================================
Files 1925 1925
Lines 132699 132699
Branches 39515 39515
=======================================
Hits 19625 19625
Misses 91101 91101
Partials 21973 21973
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. |
kyoichi-sugahara
merged commit a8364b4
into
autowarefoundation:main
37 of 39 checks passed
kaigohirao
pushed a commit
to kaigohirao/autoware.universe
that referenced
this pull request
Mar 22, 2024
…de DualReturnOutlierFilterComponent class (autowarefoundation#6654) move roi_mode_map_ definition inside DualReturnOutlierFilterComponent class Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp> Signed-off-by: kaigohirao <kaigo.hirao@proxima-ai-tech.com>
karishma1911
pushed a commit
to Interplai/autoware.universe
that referenced
this pull request
Jun 3, 2024
…de DualReturnOutlierFilterComponent class (autowarefoundation#6654) move roi_mode_map_ definition inside DualReturnOutlierFilterComponent class Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request encapsulates the roi_mode_map_ within the DualReturnOutlierFilterComponent class to improve the organization of the code and its maintainability.
Previously, roi_mode_map_ was defined in the global namespace, which could potentially lead to naming conflicts.
Tests performed
Not applicable.
Effects on system behavior
Not applicable.
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.