feat(start_planner): add a sanity check if the path is empty #6643
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com>
danielsanchezaran
requested review from
kosuke55,
kyoichi-sugahara,
soblin,
satoshi-ota,
shmpwk,
TomohitoAndo and
tkimura4
as code owners
github-actions
bot
added
the
component:planning
danielsanchezaran
added
run:build-and-test-differential
danielsanchezaran
added
the
component:planning
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #6643 +/- ##
==========================================
- Coverage 14.77% 14.76% -0.02%
==========================================
Files 1925 1925
Lines 132760 132911 +151
Branches 39544 39544
==========================================
Hits 19621 19621
- Misses 91172 91323 +151
Partials 21967 21967
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. |
danielsanchezaran
added
run:build-and-test-differential
danielsanchezaran
merged commit f5f0683
into
autowarefoundation:main
60 of 62 checks passed
kaigohirao
pushed a commit
to kaigohirao/autoware.universe
that referenced
this pull request
Mar 22, 2024
…efoundation#6643) add a sanity check if the path is empty Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com> Signed-off-by: kaigohirao <kaigo.hirao@proxima-ai-tech.com>
karishma1911
pushed a commit
to Interplai/autoware.universe
that referenced
this pull request
Jun 3, 2024
…efoundation#6643) add a sanity check if the path is empty Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
If the path for collision check happens to be empty, it might cause a crash, this PR introduces a sanity check for said cases.
Tests performed
PSim and compilation tests
Effects on system behavior
Not applicable.
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.