fix(tier4_autoware_utils): fix build error (caused by published_time_publisher.hpp)
#6641
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
github-actions
bot
added
the
component:common
satoshi-ota
changed the title
published_time_publisher.hpp)
satoshi-ota
added
the
run:build-and-test-differential
satoshi-ota
requested review from
soblin,
TakaHoribe and
takayuki5168
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6641 +/- ##
=======================================
Coverage 14.77% 14.77%
=======================================
Files 1925 1925
Lines 132760 132760
Branches 39544 39544
=======================================
Hits 19621 19621
Misses 91172 91172
Partials 21967 21967
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
@satoshi-ota I didn't test this on my machine but, how did the original PRs has passed from build tests then? Or a recent general build-and-test: |
|
Also, what is the build error? |
xmfcx
reviewed
Mar 17, 2024
common/tier4_autoware_utils/include/tier4_autoware_utils/ros/published_time_publisher.hpp
Outdated
Show resolved
Hide resolved
|
@xmfcx |
takayuki5168
approved these changes
Mar 18, 2024
|
Thanks for sharing, I will also look into catching this kind of issues with CI too. |
This was referenced Mar 18, 2024
kaigohirao
pushed a commit
to kaigohirao/autoware.universe
that referenced
this pull request
Mar 22, 2024
…_publisher.hpp`) (autowarefoundation#6641) * fix(tier4_autoware_utils): add missing header to library Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com> * fix(tier4_autoware_utils): remove std Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com> * fix Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com> --------- Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com> Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com> Co-authored-by: Takayuki Murooka <takayuki5168@gmail.com> Signed-off-by: kaigohirao <kaigo.hirao@proxima-ai-tech.com>
karishma1911
pushed a commit
to Interplai/autoware.universe
that referenced
this pull request
Jun 3, 2024
…_publisher.hpp`) (autowarefoundation#6641) * fix(tier4_autoware_utils): add missing header to library Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com> * fix(tier4_autoware_utils): remove std Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com> * fix Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com> --------- Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com> Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com> Co-authored-by: Takayuki Murooka <takayuki5168@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
FIx build error.
Tests performed
Effects on system behavior
Nothing.
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.