-
Notifications
You must be signed in to change notification settings - Fork 696
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(trajectory_follower_node): apply default param to the param file used for test #6640
Merged
kyoichi-sugahara
merged 2 commits into
autowarefoundation:main
from
kyoichi-sugahara:refactor/mpc_lateral_controller_test
Mar 18, 2024
Merged
refactor(trajectory_follower_node): apply default param to the param file used for test #6640
kyoichi-sugahara
merged 2 commits into
autowarefoundation:main
from
kyoichi-sugahara:refactor/mpc_lateral_controller_test
Mar 18, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
delete unused test files Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>
…test Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>
8c544e6
to
66300f1
Compare
takayuki5168
approved these changes
Mar 18, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #6640 +/- ##
=======================================
Coverage 14.77% 14.78%
=======================================
Files 1925 1925
Lines 132760 132759 -1
Branches 39544 39543 -1
=======================================
+ Hits 19621 19629 +8
+ Misses 91172 91167 -5
+ Partials 21967 21963 -4
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. |
6241fe0
into
autowarefoundation:main
54 of 55 checks passed
kaigohirao
pushed a commit
to kaigohirao/autoware.universe
that referenced
this pull request
Mar 22, 2024
…file used for test (autowarefoundation#6640) * apply default param to the param file used for test delete unused test files Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp> * add positive longitudinal velocity condition for straight_trajectory test Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp> --------- Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp> Signed-off-by: kaigohirao <kaigo.hirao@proxima-ai-tech.com>
karishma1911
pushed a commit
to Interplai/autoware.universe
that referenced
this pull request
Jun 3, 2024
…file used for test (autowarefoundation#6640) * apply default param to the param file used for test delete unused test files Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp> * add positive longitudinal velocity condition for straight_trajectory test Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp> --------- Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
component:control
Vehicle control algorithms and mechanisms. (auto-assigned)
run:build-and-test-differential
Mark to enable build-and-test-differential workflow. (used-by-ci)
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
lateral_controller_defaults.param.yaml
andlongitudinal_controller_defaults.param.yaml
to allign with the default parameter defined in the autoware_launchertest_lateral_controller_node.cpp
andtest_longitudinal_controller_node.cpp
are not used anymore. It seems to have been accidentally left undeleted in this PR.Tests performed
I confirmed that the test passed using the following command.
Effects on system behavior
Not applicable.
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.