Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(trajectory_follower_node): apply default param to the param file used for test #6640

Conversation

kyoichi-sugahara
Copy link
Contributor

@kyoichi-sugahara kyoichi-sugahara commented Mar 16, 2024

Description

  • apply default param to the param file used for test
    • changed parameter in lateral_controller_defaults.param.yaml and longitudinal_controller_defaults.param.yaml to allign with the default parameter defined in the autoware_launcher
  • delete unused test files
    • test_lateral_controller_node.cpp and test_longitudinal_controller_node.cpp are not used anymore. It seems to have been accidentally left undeleted in this PR.
  • add positive longitudinal velocity condition for straight_trajectory test

Tests performed

I confirmed that the test passed using the following command.

colcon test --event-handlers console_cohesion+ --packages-select trajectory_follower_node

Effects on system behavior

Not applicable.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

delete unused test files

Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>
@github-actions github-actions bot added the component:control Vehicle control algorithms and mechanisms. (auto-assigned) label Mar 16, 2024
@kyoichi-sugahara kyoichi-sugahara changed the title refctor(trajectory_follower_node): apply default param to the param file used for test refactor(trajectory_follower_node): apply default param to the param file used for test Mar 16, 2024
…test

Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>
@kyoichi-sugahara kyoichi-sugahara force-pushed the refactor/mpc_lateral_controller_test branch from 8c544e6 to 66300f1 Compare March 17, 2024 16:39
@kyoichi-sugahara kyoichi-sugahara added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Mar 18, 2024
Copy link

codecov bot commented Mar 18, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 14.78%. Comparing base (c24c3b0) to head (66300f1).
Report is 6 commits behind head on main.

Files Patch % Lines
...ectory_follower_node/test/test_controller_node.cpp 0.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6640   +/-   ##
=======================================
  Coverage   14.77%   14.78%           
=======================================
  Files        1925     1925           
  Lines      132760   132759    -1     
  Branches    39544    39543    -1     
=======================================
+ Hits        19621    19629    +8     
+ Misses      91172    91167    -5     
+ Partials    21967    21963    -4     
Flag Coverage Δ *Carryforward flag
differential 45.25% <0.00%> (?)
total 14.77% <ø> (+<0.01%) ⬆️ Carriedforward from c24c3b0

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kyoichi-sugahara kyoichi-sugahara merged commit 6241fe0 into autowarefoundation:main Mar 18, 2024
54 of 55 checks passed
@kyoichi-sugahara kyoichi-sugahara deleted the refactor/mpc_lateral_controller_test branch March 18, 2024 06:25
kaigohirao pushed a commit to kaigohirao/autoware.universe that referenced this pull request Mar 22, 2024
…file used for test (autowarefoundation#6640)

* apply default param to the param file used for test
delete unused test files

Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>

* add positive longitudinal velocity condition for straight_trajectory test

Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>

---------

Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>
Signed-off-by: kaigohirao <kaigo.hirao@proxima-ai-tech.com>
karishma1911 pushed a commit to Interplai/autoware.universe that referenced this pull request Jun 3, 2024
…file used for test (autowarefoundation#6640)

* apply default param to the param file used for test
delete unused test files

Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>

* add positive longitudinal velocity condition for straight_trajectory test

Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>

---------

Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:control Vehicle control algorithms and mechanisms. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants